[Interpreter] Introduce InterpreterCompilationJob

src/compiler.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_H_
 #define V8_COMPILER_H_
 
 #include <memory>
 
 #include "src/allocation.h"
@@ skipping 102 matching lines @@
       Handle<Script> script, ParseInfo* info, int source_length);
 
   // Create a shared function info object (the code may be lazily compiled).
   static Handle<SharedFunctionInfo> GetSharedFunctionInfo(
       FunctionLiteral* node, Handle<Script> script, CompilationInfo* outer);
 
   // Create a shared function info object for a native function literal.
   static Handle<SharedFunctionInfo> GetSharedFunctionInfoForNative(
       v8::Extension* extension, Handle<String> name);
 
+  // Registers weak object to optimized code dependencies.
+  static void RegisterWeakObjectsInOptimizedCode(Handle<Code> code);

[Michael Starzinger, 2016/08/16 08:46:40]

IMHO this doesn't belong into the "Compiler" interface either. It should
actually be part of the code generation and is only in compiler.cc in order to
be shared between Crankshaft and TurboFan. Can we move it back onto the
CompilationJob for now. We can even copy the TODO from the implementation out
into interface to clarify that this is a temporary workaround ...

// TODO(turbofan): Move this to pipeline.cc once Crankshaft dies.

[rmcilroy, 2016/08/16 11:10:44]

Done.

+
   // ===========================================================================
   // The following family of methods provides support for OSR. Code generated
   // for entry via OSR might not be suitable for normal entry, hence will be
   // returned directly to the caller.
   //
   // Please note this interface is the only part dealing with {Code} objects
   // directly. Other methods are agnostic to {Code} and can use an interpreter
   // instead of generating JIT code for a function at all.
 
   // Generate and return optimized code for OSR, or empty handle on failure.
@@ skipping 397 matching lines @@
   JavaScriptFrame* osr_frame_ = nullptr;
 
   Vector<const char> debug_name_;
 
   DISALLOW_COPY_AND_ASSIGN(CompilationInfo);
 };
 
 // A base class for compilation jobs intended to run concurrent to the main
 // thread. The job is split into three phases which are called in sequence on
 // different threads and with different limitations:
-//  1) CreateGraph:   Runs on main thread. No major limitations.
-//  2) OptimizeGraph: Runs concurrently. No heap allocation or handle derefs.
-//  3) GenerateCode:  Runs on main thread. No dependency changes.
+//  1) PrepareJob:   Runs on main thread. No major limitations.
+//  2) ExecuteJob:   Runs concurrently. No heap allocation or handle derefs.
+//  3) FinalizeJob:  Runs on main thread. No dependency changes.
 //
-// Each of the three phases can either fail or succeed. Apart from their return
-// value, the status of the phase last run can be checked using {last_status()}
-// as well. When failing we distinguish between the following levels:
-//  a) AbortOptimization: Persistent failure, disable future optimization.
-//  b) RetryOptimzation: Transient failure, try again next time.
+// Each of the three phases can either fail or succeed. The current state of
+// the job can be checked using {state()}.
 class CompilationJob {
  public:
-  explicit CompilationJob(CompilationInfo* info, const char* compiler_name)
-      : info_(info), compiler_name_(compiler_name), last_status_(SUCCEEDED) {}
+  enum Status { SUCCEEDED, FAILED };
+  enum class State {
+    kReadyToPrepare,
+    kReadyToExecute,
+    kReadyToFinalize,
+    kSucceeded,
+    kFailed,
+  };
+
+  explicit CompilationJob(CompilationInfo* info, const char* compiler_name,
+                          State initial_state = State::kReadyToPrepare)
+      : info_(info), compiler_name_(compiler_name), state_(initial_state) {}
   virtual ~CompilationJob() {}
 
-  enum Status { FAILED, SUCCEEDED };
+  // Prepare the compile job. Must be called on the main thread.
+  MUST_USE_RESULT Status PrepareJob();
 
-  MUST_USE_RESULT Status CreateGraph();
-  MUST_USE_RESULT Status OptimizeGraph();
-  MUST_USE_RESULT Status GenerateCode();
+  // Executes the compile job. Can called off the main thread.

[Michael Starzinger, 2016/08/16 08:46:40]

nit: s/Can called/Can be called/

[rmcilroy, 2016/08/16 11:10:44]

Done.

+  MUST_USE_RESULT Status ExecuteJob();
 
-  Status last_status() const { return last_status_; }
-  CompilationInfo* info() const { return info_; }
-  Isolate* isolate() const { return info()->isolate(); }
+  // Finalizes the compile job. Must be called on the main thread.
+  MUST_USE_RESULT Status FinalizeJob();
 
+  // Report a transient failure, try again next time. Should only be called on
+  // optimization compilation jobs.
   Status RetryOptimization(BailoutReason reason) {
+    DCHECK(info_->IsOptimizing());
     info_->RetryOptimization(reason);
-    return SetLastStatus(FAILED);
+    state_ = State::kFailed;
+    return FAILED;
   }
 
+  // Report a persistent failure, disable future optimization on the function.
+  // Should only be called on optimization compilation jobs.
   Status AbortOptimization(BailoutReason reason) {
+    DCHECK(info_->IsOptimizing());
     info_->AbortOptimization(reason);
-    return SetLastStatus(FAILED);
+    state_ = State::kFailed;
+    return FAILED;
   }
 
   void RecordOptimizationStats();
 
+  State state() const { return state_; }
+  CompilationInfo* info() const { return info_; }
+  Isolate* isolate() const { return info()->isolate(); }
+
  protected:
-  void RegisterWeakObjectsInOptimizedCode(Handle<Code> code);
-
   // Overridden by the actual implementation.
-  virtual Status CreateGraphImpl() = 0;
-  virtual Status OptimizeGraphImpl() = 0;
-  virtual Status GenerateCodeImpl() = 0;
+  virtual Status PrepareJobImpl() = 0;
+  virtual Status ExecuteJobImpl() = 0;
+  virtual Status FinalizeJobImpl() = 0;
 
  private:
   CompilationInfo* info_;
-  base::TimeDelta time_taken_to_create_graph_;
-  base::TimeDelta time_taken_to_optimize_;
-  base::TimeDelta time_taken_to_codegen_;
+  base::TimeDelta time_taken_to_prepare_;
+  base::TimeDelta time_taken_to_execute_;
+  base::TimeDelta time_taken_to_finalize_;
   const char* compiler_name_;
-  Status last_status_;
+  State state_;
 
-  MUST_USE_RESULT Status SetLastStatus(Status status) {
-    last_status_ = status;
-    return last_status_;
+  MUST_USE_RESULT Status UpdateState(Status status, State next_state) {
+    if (status == SUCCEEDED)

[Michael Starzinger, 2016/08/16 08:46:40]

nit: Curly braces around bodies of multi-line if statements.

[rmcilroy, 2016/08/16 11:10:44]

Done.

+      state_ = next_state;
+    else
+      state_ = State::kFailed;
+    return status;
   }
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_H_