Remove GN back-compat toolchain args code.

Remove GN back-compat toolchain args code.

All callers of toolchain_args as a function have been update to use the new
variable. The shim code can be removed.

BUG=634446
Committed: https://crrev.com/b68d6d77e73624422dce58601eafad9d8e5d4f14
Cr-Commit-Position: refs/heads/master@{#411767}

[brettw, 2016-08-12 20:00:59]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[brettw, 2016-08-12 20:01:03]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 20:02:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-08-12 20:04:25]

lgtm

https://codereview.chromium.org/2240293002/diff/1/tools/gn/function_toolchain.cc
File tools/gn/function_toolchain.cc (left):

https://codereview.chromium.org/2240293002/diff/1/tools/gn/function_toolchain...
tools/gn/function_toolchain.cc:1045: extern const char kToolchainArgs[] =
"toolchain_args";
Oh, those extern's were weird. I'm surprised that worked.

[brettw, 2016-08-12 20:11:13]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-08-12 20:11:16]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-08-12 20:11:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 21:12:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 21:15:59]

Description was changed from

==========
Remove GN back-compat toolchain args code.

All callers of toolchain_args as a function have been update to use the new
variable. The shim code can be removed.

BUG=634446
==========

to

==========
Remove GN back-compat toolchain args code.

All callers of toolchain_args as a function have been update to use the new
variable. The shim code can be removed.

BUG=634446

Committed: https://crrev.com/b68d6d77e73624422dce58601eafad9d8e5d4f14
Cr-Commit-Position: refs/heads/master@{#411767}
==========

[commit-bot: I haz the power, 2016-08-12 21:16:00]

Patchset 1 (id:??) landed as
https://crrev.com/b68d6d77e73624422dce58601eafad9d8e5d4f14
Cr-Commit-Position: refs/heads/master@{#411767}