Remove GN back-compat toolchain args code.

tools/gn/function_toolchain.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <limits>
 #include <utility>
 
 #include "tools/gn/err.h"
 #include "tools/gn/functions.h"
@@ skipping 1024 matching lines @@
   }
 
   // Make sure there weren't any vars set in this tool that were unused.
   if (!block_scope.CheckForUnusedVars(err))
     return Value();
 
   toolchain->SetTool(tool_type, std::move(tool));
   return Value();
 }
 
-extern const char kToolchainArgs[] = "toolchain_args";

[scottmg, 2016/08/12 20:04:24]

Oh, those extern's were weird. I'm surprised that worked.

-extern const char kToolchainArgs_HelpShort[] =
-    "toolchain_args: Set build arguments for toolchain build setup.";
-extern const char kToolchainArgs_Help[] =
-    "toolchain_args: Set build arguments for toolchain build setup.\n"
-    "\n"
-    "  DEPRECATED. Instead use:\n"
-    "    toolchain_args = { ... }\n"
-    "\n"
-    "  See \"gn help toolchain\" for documentation.\n";
-
-Value RunToolchainArgs(Scope* scope,
-                       const FunctionCallNode* function,
-                       const std::vector<Value>& args,
-                       BlockNode* block,
-                       Err* err) {
-  // This is a backwards-compatible shim that converts the old form of:
-  //   toolchain_args() {
-  //     foo = bar
-  //   }
-  // to the new form:
-  //   toolchain_args = {
-  //     foo = bar
-  //   }
-  // It will be deleted when all users of toolchain_args as a function are
-  // deleted.
-  if (!args.empty()) {
-    *err = Err(function->function(), "This function takes no arguments.");
-    return Value();
-  }
-
-  std::unique_ptr<Scope> block_scope(new Scope(scope));
-  block->Execute(block_scope.get(), err);
-  if (err->has_error())
-    return Value();
-
-  block_scope->DetachFromContaining();
-  scope->SetValue("toolchain_args", Value(function, std::move(block_scope)),
-                  function);
-  return Value();
-}
-
 }  // namespace functions