Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2240283002: Reload: Don't free the saved class table while another thread may be reading it. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
Cutch, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reload: Don't free the saved class table while another thread may be reading it. Fixes #27016. R=asiva@google.com, johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/6b5f29fb70bd41184969142b33ca03521c3dcbc9

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M runtime/vm/class_table.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/class_table.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/isolate_reload.cc View 1 1 chunk +6 lines, -2 lines 2 comments Download
M runtime/vm/unit_test.cc View 1 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rmacnak
4 years, 4 months ago (2016-08-12 21:01:50 UTC) #2
Cutch
LGTM!
4 years, 4 months ago (2016-08-12 21:06:34 UTC) #3
siva
https://codereview.chromium.org/2240283002/diff/20001/runtime/vm/isolate_reload.cc File runtime/vm/isolate_reload.cc (right): https://codereview.chromium.org/2240283002/diff/20001/runtime/vm/isolate_reload.cc#newcode933 runtime/vm/isolate_reload.cc:933: class_table->AddOldTable(local_saved_class_table); When does saved_num_cids_ get set to 0?
4 years, 4 months ago (2016-08-12 21:10:45 UTC) #4
rmacnak
https://codereview.chromium.org/2240283002/diff/20001/runtime/vm/isolate_reload.cc File runtime/vm/isolate_reload.cc (right): https://codereview.chromium.org/2240283002/diff/20001/runtime/vm/isolate_reload.cc#newcode933 runtime/vm/isolate_reload.cc:933: class_table->AddOldTable(local_saved_class_table); On 2016/08/12 21:10:45, siva wrote: > When does ...
4 years, 4 months ago (2016-08-12 21:15:29 UTC) #5
siva
lgtm
4 years, 4 months ago (2016-08-12 22:51:34 UTC) #6
rmacnak
4 years, 4 months ago (2016-08-12 23:12:31 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6b5f29fb70bd41184969142b33ca03521c3dcbc9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698