Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Side by Side Diff: runtime/vm/class_table.h

Issue 2240283002: Reload: Don't free the saved class table while another thread may be reading it. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/class_table.cc » ('j') | runtime/vm/isolate_reload.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_CLASS_TABLE_H_ 5 #ifndef VM_CLASS_TABLE_H_
6 #define VM_CLASS_TABLE_H_ 6 #define VM_CLASS_TABLE_H_
7 7
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/bitfield.h" 9 #include "vm/bitfield.h"
10 #include "vm/globals.h" 10 #include "vm/globals.h"
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 static intptr_t SizeOffsetFor(intptr_t cid, bool is_new_space); 231 static intptr_t SizeOffsetFor(intptr_t cid, bool is_new_space);
232 232
233 ClassHeapStats* StatsWithUpdatedSize(intptr_t cid); 233 ClassHeapStats* StatsWithUpdatedSize(intptr_t cid);
234 234
235 void AllocationProfilePrintJSON(JSONStream* stream); 235 void AllocationProfilePrintJSON(JSONStream* stream);
236 void ResetAllocationAccumulators(); 236 void ResetAllocationAccumulators();
237 237
238 void PrintToJSONObject(JSONObject* object); 238 void PrintToJSONObject(JSONObject* object);
239 #endif // !PRODUCT 239 #endif // !PRODUCT
240 240
241 void AddOldTable(RawClass** old_table);
241 // Deallocates table copies. Do not call during concurrent access to table. 242 // Deallocates table copies. Do not call during concurrent access to table.
242 void FreeOldTables(); 243 void FreeOldTables();
243 244
244 void SetTraceAllocationFor(intptr_t cid, bool trace); 245 void SetTraceAllocationFor(intptr_t cid, bool trace);
245 bool TraceAllocationFor(intptr_t cid); 246 bool TraceAllocationFor(intptr_t cid);
246 247
247 private: 248 private:
248 friend class GCMarker; 249 friend class GCMarker;
249 friend class ScavengerVisitor; 250 friend class ScavengerVisitor;
250 friend class ClassHeapStatsTestHelper; 251 friend class ClassHeapStatsTestHelper;
(...skipping 18 matching lines...) Expand all
269 void UpdateLiveOld(intptr_t cid, intptr_t size, intptr_t count = 1); 270 void UpdateLiveOld(intptr_t cid, intptr_t size, intptr_t count = 1);
270 void UpdateLiveNew(intptr_t cid, intptr_t size); 271 void UpdateLiveNew(intptr_t cid, intptr_t size);
271 #endif // !PRODUCT 272 #endif // !PRODUCT
272 273
273 DISALLOW_COPY_AND_ASSIGN(ClassTable); 274 DISALLOW_COPY_AND_ASSIGN(ClassTable);
274 }; 275 };
275 276
276 } // namespace dart 277 } // namespace dart
277 278
278 #endif // VM_CLASS_TABLE_H_ 279 #endif // VM_CLASS_TABLE_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/class_table.cc » ('j') | runtime/vm/isolate_reload.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698