Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2240273002: Move |DidOverscrollParams| from |content::| to "ui/events/blink" (Closed)

Created:
4 years, 4 months ago by chongz
Modified:
4 years, 4 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, tdresser+watch_chromium.org, shuchen+watch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move |DidOverscrollParams| from |content::| to "ui/events/blink" This CL moves |DidOverscrollParams| from |content::| to |ui::|, so it can be accessed by |InputHandlerProxy| in "ui/events/blink". Adds dependency: 1. content/common : ui/events/blink 2. content/renderer/mus : ui/events/blink BUG=637393 Committed: https://crrev.com/a8ba91fcbea546ad0922f99aa89fc19670c3b129 Cr-Commit-Position: refs/heads/master@{#412344}

Patch Set 1 : Move DidOverscrollParams to ui:: #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -110 lines) Patch
M content/browser/android/overscroll_controller_android.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/android/overscroll_controller_android.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/android/synchronous_compositor_host.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/android/synchronous_compositor_host.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_client.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_impl_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/mock_input_router_client.h View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/mock_input_router_client.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/android/sync_compositor_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/input/did_overscroll_params.h View 1 chunk +0 lines, -25 lines 0 comments Download
D content/common/input/did_overscroll_params.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M content/common/input/input_event_ack.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/input/input_event_ack.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input_messages.h View 4 chunks +3 lines, -3 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/input/input_event_filter.h View 3 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/input/input_event_filter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_manager.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_manager_client.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/input/render_widget_input_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/input/render_widget_input_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/input/render_widget_input_handler_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.h View 3 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/blink/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
A + ui/events/blink/did_overscroll_params.h View 2 chunks +6 lines, -7 lines 3 comments Download
A + ui/events/blink/did_overscroll_params.cc View 1 chunk +4 lines, -4 lines 2 comments Download
M ui/events/blink/input_handler_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 38 (27 generated)
chongz
dtapuska@ PTAL, thanks! https://codereview.chromium.org/2240273002/diff/60001/ui/events/blink/did_overscroll_params.cc File ui/events/blink/did_overscroll_params.cc (left): https://codereview.chromium.org/2240273002/diff/60001/ui/events/blink/did_overscroll_params.cc#oldcode11 ui/events/blink/did_overscroll_params.cc:11: } Wrong file for diff?
4 years, 4 months ago (2016-08-15 13:11:42 UTC) #20
dtapuska
lgtm https://codereview.chromium.org/2240273002/diff/60001/ui/events/blink/did_overscroll_params.h File ui/events/blink/did_overscroll_params.h (right): https://codereview.chromium.org/2240273002/diff/60001/ui/events/blink/did_overscroll_params.h#newcode13 ui/events/blink/did_overscroll_params.h:13: struct DidOverscrollParams { Do you need a export ...
4 years, 4 months ago (2016-08-15 18:50:48 UTC) #21
chongz
jam@ PTAL, thanks! https://codereview.chromium.org/2240273002/diff/60001/ui/events/blink/did_overscroll_params.h File ui/events/blink/did_overscroll_params.h (right): https://codereview.chromium.org/2240273002/diff/60001/ui/events/blink/did_overscroll_params.h#newcode13 ui/events/blink/did_overscroll_params.h:13: struct DidOverscrollParams { On 2016/08/15 18:50:47, ...
4 years, 4 months ago (2016-08-15 19:09:13 UTC) #24
chongz
ncarter@ PTAL at this CL, thanks! (seems jam@ is OOO.)
4 years, 4 months ago (2016-08-16 15:01:00 UTC) #27
ncarter (slow)
https://codereview.chromium.org/2240273002/diff/60001/ui/events/blink/did_overscroll_params.cc File ui/events/blink/did_overscroll_params.cc (left): https://codereview.chromium.org/2240273002/diff/60001/ui/events/blink/did_overscroll_params.cc#oldcode11 ui/events/blink/did_overscroll_params.cc:11: } On 2016/08/15 13:11:42, chongz wrote: > Wrong file ...
4 years, 4 months ago (2016-08-16 19:26:42 UTC) #28
ncarter (slow)
content lgtm
4 years, 4 months ago (2016-08-16 19:26:56 UTC) #29
chongz
kenrb@ PTAL at IPC, thanks!
4 years, 4 months ago (2016-08-16 19:37:34 UTC) #31
kenrb
lgtm
4 years, 4 months ago (2016-08-16 20:07:18 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240273002/60001
4 years, 4 months ago (2016-08-16 20:45:07 UTC) #34
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 4 months ago (2016-08-16 21:39:34 UTC) #36
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 21:42:08 UTC) #38
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8ba91fcbea546ad0922f99aa89fc19670c3b129
Cr-Commit-Position: refs/heads/master@{#412344}

Powered by Google App Engine
This is Rietveld 408576698