Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2240263004: Allow injecting a PrefService into ChromeComponentUpdaterConfigurator. (Closed)

Created:
4 years, 4 months ago by Sorin Jianu
Modified:
4 years, 4 months ago
Reviewers:
waffles, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow injecting a PrefService into ChromeComponentUpdaterConfigurator. This is a mechanical change for the purpose of testing future changes related to group policies in the component updater. R=sky@chromium.org TBR=waffles@chromium.org BUG=637452 Committed: https://crrev.com/dd63a936012d94f7ad6f6e36f09e5de68262c4e1 Cr-Commit-Position: refs/heads/master@{#411935}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -26 lines) Patch
M chrome/browser/browser_process_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/chrome_component_updater_configurator.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/component_updater/chrome_component_updater_configurator.cc View 5 chunks +15 lines, -6 lines 0 comments Download
M chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc View 7 chunks +43 lines, -16 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Sorin Jianu
John, please, I need an owner's approval for changes to browser_process_impl.cc
4 years, 4 months ago (2016-08-12 22:59:19 UTC) #5
Sorin Jianu
Sky, I need an owner's review for chrome_browser_impl.cc please. It would be nice to land ...
4 years, 4 months ago (2016-08-12 23:24:18 UTC) #8
sky
browser_process_impl.cc LGTM, I did not look at the component_updater side.
4 years, 4 months ago (2016-08-13 15:57:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240263004/1
4 years, 4 months ago (2016-08-15 02:32:46 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 03:23:05 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dd63a936012d94f7ad6f6e36f09e5de68262c4e1 Cr-Commit-Position: refs/heads/master@{#411935}
4 years, 4 months ago (2016-08-15 03:26:53 UTC) #17
waffles
4 years, 4 months ago (2016-08-16 19:57:32 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698