Allow injecting a PrefService into ChromeComponentUpdaterConfigurator.

chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <memory>
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/component_updater/chrome_component_updater_configurator.h"
 #include "components/component_updater/component_updater_switches.h"
 #include "components/component_updater/component_updater_url_constants.h"
 #include "components/component_updater/configurator_impl.h"
+#include "components/prefs/testing_pref_service.h"
 #include "components/update_client/configurator.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace component_updater {
 
-TEST(ChromeComponentUpdaterConfiguratorTest, TestDisablePings) {
+class ChromeComponentUpdaterConfiguratorTest : public testing::Test {
+ public:
+  ChromeComponentUpdaterConfiguratorTest();
+  ~ChromeComponentUpdaterConfiguratorTest() override{};
+
+ protected:
+  PrefService* pref_service() { return pref_service_.get(); }
+
+ private:
+  std::unique_ptr<TestingPrefServiceSimple> pref_service_;
+
+  DISALLOW_COPY_AND_ASSIGN(ChromeComponentUpdaterConfiguratorTest);
+};
+
+ChromeComponentUpdaterConfiguratorTest::ChromeComponentUpdaterConfiguratorTest()
+    : pref_service_(new TestingPrefServiceSimple()) {}
+
+TEST_F(ChromeComponentUpdaterConfiguratorTest, TestDisablePings) {
   base::CommandLine cmdline(*base::CommandLine::ForCurrentProcess());
   cmdline.AppendSwitchASCII(switches::kComponentUpdater, "disable-pings");
 
-  const auto config(MakeChromeComponentUpdaterConfigurator(&cmdline, nullptr));
+  const auto config(MakeChromeComponentUpdaterConfigurator(&cmdline, nullptr,
+                                                           pref_service()));
 
   const std::vector<GURL> pingUrls = config->PingUrl();
   EXPECT_TRUE(pingUrls.empty());
 }
 
-TEST(ChromeComponentUpdaterConfiguratorTest, TestFastUpdate) {
+TEST_F(ChromeComponentUpdaterConfiguratorTest, TestFastUpdate) {
   base::CommandLine cmdline(*base::CommandLine::ForCurrentProcess());
   cmdline.AppendSwitchASCII(switches::kComponentUpdater, "fast-update");
 
-  const auto config(MakeChromeComponentUpdaterConfigurator(&cmdline, nullptr));
+  const auto config(MakeChromeComponentUpdaterConfigurator(&cmdline, nullptr,
+                                                           pref_service()));
 
   CHECK_EQ(10, config->InitialDelay());
   CHECK_EQ(6 * 60 * 60, config->NextCheckDelay());
   CHECK_EQ(1, config->StepDelay());
   CHECK_EQ(2, config->OnDemandDelay());
   CHECK_EQ(10, config->UpdateDelay());
 }
 
-TEST(ChromeComponentUpdaterConfiguratorTest, TestOverrideUrl) {
+TEST_F(ChromeComponentUpdaterConfiguratorTest, TestOverrideUrl) {
   const char overrideUrl[] = "http://0.0.0.0/";
 
   base::CommandLine cmdline(*base::CommandLine::ForCurrentProcess());
 
   std::string val = "url-source";
   val.append("=");
   val.append(overrideUrl);
   cmdline.AppendSwitchASCII(switches::kComponentUpdater, val.c_str());
 
-  const auto config(MakeChromeComponentUpdaterConfigurator(&cmdline, nullptr));
+  const auto config(MakeChromeComponentUpdaterConfigurator(&cmdline, nullptr,
+                                                           pref_service()));
 
   const std::vector<GURL> urls = config->UpdateUrl();
 
   ASSERT_EQ(1U, urls.size());
   ASSERT_EQ(overrideUrl, urls.at(0).possibly_invalid_spec());
 }
 
-TEST(ChromeComponentUpdaterConfiguratorTest, TestSwitchRequestParam) {
+TEST_F(ChromeComponentUpdaterConfiguratorTest, TestSwitchRequestParam) {
   base::CommandLine cmdline(*base::CommandLine::ForCurrentProcess());
   cmdline.AppendSwitchASCII(switches::kComponentUpdater, "test-request");
 
-  const auto config(MakeChromeComponentUpdaterConfigurator(&cmdline, nullptr));
+  const auto config(MakeChromeComponentUpdaterConfigurator(&cmdline, nullptr,
+                                                           pref_service()));
 
   EXPECT_FALSE(config->ExtraRequestParams().empty());
 }
 
-TEST(ChromeComponentUpdaterConfiguratorTest, TestUpdaterDefaultUrl) {
+TEST_F(ChromeComponentUpdaterConfiguratorTest, TestUpdaterDefaultUrl) {
   base::CommandLine cmdline(*base::CommandLine::ForCurrentProcess());
-  const auto config(MakeChromeComponentUpdaterConfigurator(&cmdline, nullptr));
+  const auto config(MakeChromeComponentUpdaterConfigurator(&cmdline, nullptr,
+                                                           pref_service()));
   const auto urls = config->UpdateUrl();
 
   // Expect the default url to be cryptographically secure.
   EXPECT_GE(urls.size(), 1u);
   EXPECT_TRUE(urls.front().SchemeIsCryptographic());
 }
 
-TEST(ChromeComponentUpdaterConfiguratorTest, TestEnabledCupSigning) {
+TEST_F(ChromeComponentUpdaterConfiguratorTest, TestEnabledCupSigning) {
   base::CommandLine cmdline(*base::CommandLine::ForCurrentProcess());
-  const auto config(MakeChromeComponentUpdaterConfigurator(&cmdline, nullptr));
+  const auto config(MakeChromeComponentUpdaterConfigurator(&cmdline, nullptr,
+                                                           pref_service()));
 
   EXPECT_TRUE(config->EnabledCupSigning());
 }
 
-TEST(ChromeComponentUpdaterConfiguratorTest, TestUseEncryption) {
+TEST_F(ChromeComponentUpdaterConfiguratorTest, TestUseEncryption) {
   base::CommandLine* cmdline = base::CommandLine::ForCurrentProcess();
-  const auto config(MakeChromeComponentUpdaterConfigurator(cmdline, nullptr));
+  const auto config(
+      MakeChromeComponentUpdaterConfigurator(cmdline, nullptr, pref_service()));
 
   const auto urls = config->UpdateUrl();
   ASSERT_EQ(2u, urls.size());
   ASSERT_STREQ(kUpdaterDefaultUrl, urls[0].spec().c_str());
   ASSERT_STREQ(kUpdaterFallbackUrl, urls[1].spec().c_str());
 
   ASSERT_EQ(config->UpdateUrl(), config->PingUrl());
 
   // Use the configurator implementation to test the filtering of
   // unencrypted URLs.
   {
     const ConfiguratorImpl config(cmdline, nullptr, true);
     const auto urls = config.UpdateUrl();
     ASSERT_EQ(1u, urls.size());
     ASSERT_STREQ(kUpdaterDefaultUrl, urls[0].spec().c_str());
     ASSERT_EQ(config.UpdateUrl(), config.PingUrl());
   }
 
   {
     const ConfiguratorImpl config(cmdline, nullptr, false);
     const auto urls = config.UpdateUrl();
     ASSERT_EQ(2u, urls.size());
     ASSERT_STREQ(kUpdaterDefaultUrl, urls[0].spec().c_str());
     ASSERT_STREQ(kUpdaterFallbackUrl, urls[1].spec().c_str());
     ASSERT_EQ(config.UpdateUrl(), config.PingUrl());
   }
 }
 
-TEST(ChromeComponentUpdaterConfiguratorTest, TestEnabledComponentUpdates) {
+TEST_F(ChromeComponentUpdaterConfiguratorTest, TestEnabledComponentUpdates) {
   base::CommandLine cmdline(*base::CommandLine::ForCurrentProcess());
-  const auto config(MakeChromeComponentUpdaterConfigurator(&cmdline, nullptr));
+  const auto config(MakeChromeComponentUpdaterConfigurator(&cmdline, nullptr,
+                                                           pref_service()));
   EXPECT_TRUE(config->EnabledComponentUpdates());
 }
 
 }  // namespace component_updater