[Downloads/Phone] Add button to icon row for offlining pages

[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

* Removes an unused icon.

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324
For lint relanding:
TBR=twellington

Committed: https://crrev.com/35a583985d859d19cd2de1efb7a5b8bb06bcda77
Cr-Commit-Position: refs/heads/master@{#411777}

[gone, 2016-08-12 18:27:23]

Description was changed from

==========
[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324
==========

to

==========
[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

* Removes an unused icon.

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324
==========

[gone, 2016-08-12 18:27:31]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 18:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-08-12 18:29:44]

dfalcantara@chromium.org changed reviewers:
+ twellington@chromium.org

[gone, 2016-08-12 18:29:44]

+twellington for review

+dimich as FYI for where the hookup is going

[Theresa, 2016-08-12 18:53:15]

lgtm % two comments

https://codereview.chromium.org/2240263002/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/icon_row_menu_item.xml (right):

https://codereview.chromium.org/2240263002/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/icon_row_menu_item.xml:50:
android:background="?attr/listChoiceBackgroundIndicator"
Can we define common style for these buttons?

https://codereview.chromium.org/2240263002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
(right):

https://codereview.chromium.org/2240263002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java:116:
offlineMenuItem.setVisible(false);
If it's not enabled we don't need to do the rest of this (set enabled/tint)
right?

[gone, 2016-08-12 19:09:19]

https://codereview.chromium.org/2240263002/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/icon_row_menu_item.xml (right):

https://codereview.chromium.org/2240263002/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/icon_row_menu_item.xml:50:
android:background="?attr/listChoiceBackgroundIndicator"
On 2016/08/12 18:53:15, Theresa Wellington wrote:
> Can we define common style for these buttons?

Done.

https://codereview.chromium.org/2240263002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
(right):

https://codereview.chromium.org/2240263002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java:116:
offlineMenuItem.setVisible(false);
On 2016/08/12 18:53:15, Theresa Wellington wrote:
> If it's not enabled we don't need to do the rest of this (set enabled/tint)
> right?

Done.

[gone, 2016-08-12 19:09:25]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-08-12 19:09:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2240263002/#ps20001
(title: "Comments")

[commit-bot: I haz the power, 2016-08-12 19:10:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 19:42:19]

Description was changed from

==========
[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

* Removes an unused icon.

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324
==========

to

==========
[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

* Removes an unused icon.

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324
==========

[commit-bot: I haz the power, 2016-08-12 19:42:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-12 19:43:59]

Description was changed from

==========
[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

* Removes an unused icon.

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324
==========

to

==========
[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

* Removes an unused icon.

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324

Committed: https://crrev.com/ca8c5868dbd7ea6734cb80938618ab6870d96ba3
Cr-Commit-Position: refs/heads/master@{#411736}
==========

[commit-bot: I haz the power, 2016-08-12 19:44:00]

Patchset 2 (id:??) landed as
https://crrev.com/ca8c5868dbd7ea6734cb80938618ab6870d96ba3
Cr-Commit-Position: refs/heads/master@{#411736}

[gone, 2016-08-12 20:29:24]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2237003006/ by dfalcantara@chromium.org.

The reason for reverting is: Lint errors..

[gone, 2016-08-12 20:39:10]

Description was changed from

==========
[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

* Removes an unused icon.

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324

Committed: https://crrev.com/ca8c5868dbd7ea6734cb80938618ab6870d96ba3
Cr-Commit-Position: refs/heads/master@{#411736}
==========

to

==========
[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

* Removes an unused icon.

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324

Committed: https://crrev.com/ca8c5868dbd7ea6734cb80938618ab6870d96ba3
Cr-Commit-Position: refs/heads/master@{#411736}
==========

[gone, 2016-08-12 20:41:44]

Description was changed from

==========
[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

* Removes an unused icon.

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324

Committed: https://crrev.com/ca8c5868dbd7ea6734cb80938618ab6870d96ba3
Cr-Commit-Position: refs/heads/master@{#411736}
==========

to

==========
[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

* Removes an unused icon.

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324

For lint relanding:
TBR=twellington
==========

[gone, 2016-08-12 20:41:50]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-08-12 20:41:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2240263002/#ps40001
(title: "Fix lint")

[commit-bot: I haz the power, 2016-08-12 20:42:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-08-12 20:42:40]

The CQ bit was unchecked by dfalcantara@chromium.org

[gone, 2016-08-12 20:45:43]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-08-12 20:45:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2240263002/#ps60001
(title: "Really fix")

[commit-bot: I haz the power, 2016-08-12 20:46:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-08-12 20:54:04]

The CQ bit was unchecked by dfalcantara@chromium.org

[gone, 2016-08-12 20:55:05]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-08-12 20:55:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 21:28:08]

Description was changed from

==========
[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

* Removes an unused icon.

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324

For lint relanding:
TBR=twellington
==========

to

==========
[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

* Removes an unused icon.

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324

For lint relanding:
TBR=twellington
==========

[commit-bot: I haz the power, 2016-08-12 21:28:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-12 21:30:04]

Description was changed from

==========
[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

* Removes an unused icon.

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324

For lint relanding:
TBR=twellington
==========

to

==========
[Downloads/Phone] Add button to icon row for offlining pages

* Generalizes the AppMenu[Adapter/PropertiesDelegate] code to support
  up to five items.

* Adds an icon to the phone/compressed tablet menu that is for
  offlining a page.

* Hides it behind a flag called: --enable-offline-page-downloading

* Removes an unused icon.

- Not hooked up to anything yet.

- The icon is off-center because the asset provided by go/icons is
  off-center.  Waiting for a new one from UX.

BUG=616324

For lint relanding:
TBR=twellington

Committed: https://crrev.com/35a583985d859d19cd2de1efb7a5b8bb06bcda77
Cr-Commit-Position: refs/heads/master@{#411777}
==========

[commit-bot: I haz the power, 2016-08-12 21:30:05]

Patchset 4 (id:??) landed as
https://crrev.com/35a583985d859d19cd2de1efb7a5b8bb06bcda77
Cr-Commit-Position: refs/heads/master@{#411777}