MD Settings: Use dom-if for the profile disconnect dialog.

chrome/test/data/webui/settings/people_page_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings_people_page', function() {
   /**
    * @constructor
    * @implements {settings.ProfileInfoBrowserProxy}
    * @extends {settings.TestBrowserProxy}
    */
@@ skipping 154 matching lines @@
       });
 
       teardown(function() { peoplePage.remove(); });
 
       test('GetProfileInfo', function() {
         var disconnectButton = null;
         return browserProxy.whenCalled('getSyncStatus').then(function() {
           Polymer.dom.flush();
           disconnectButton = peoplePage.$$('#disconnectButton');
           assertTrue(!!disconnectButton);
+          assertFalse(!!peoplePage.$$('#disconnectDialog'));
 
           MockInteractions.tap(disconnectButton);
           Polymer.dom.flush();
+        }).then(function() {
+          assertTrue(peoplePage.$$('#disconnectDialog').open);
+          assertFalse(peoplePage.$$('#deleteProfile').hidden);
 
-          assertTrue(peoplePage.$.disconnectDialog.open);
           var deleteProfileCheckbox = peoplePage.$$('#deleteProfile');
           assertTrue(!!deleteProfileCheckbox);
           assertLT(0, deleteProfileCheckbox.clientHeight);
 
-          var disconnectConfirm = peoplePage.$.disconnectConfirm;
+          var disconnectConfirm = peoplePage.$$('#disconnectConfirm');
           assertTrue(!!disconnectConfirm);
           assertFalse(disconnectConfirm.hidden);
 
           var popstatePromise = new Promise(function(resolve) {
             listenOnce(window, 'popstate', resolve);
           });
 
           MockInteractions.tap(disconnectConfirm);
 
           return popstatePromise;
         }).then(function() {
           return browserProxy.whenCalled('signOut');
         }).then(function(deleteProfile) {
           assertFalse(deleteProfile);
 
           cr.webUIListenerCallback('sync-status-changed', {
             signedIn: true,
             domain: 'example.com',
           });
           Polymer.dom.flush();
 
-          assertFalse(peoplePage.$.disconnectDialog.open);
+          assertFalse(!!peoplePage.$$('#disconnectDialog'));
           MockInteractions.tap(disconnectButton);
           Polymer.dom.flush();
 
-          assertTrue(peoplePage.$.disconnectDialog.open);
-          var deleteProfileCheckbox = peoplePage.$$('#deleteProfile');
-          assertTrue(!!deleteProfileCheckbox);
-          assertEquals(0, deleteProfileCheckbox.clientHeight);
+          return new Promise(function(resolve) { peoplePage.async(resolve); });
+        }).then(function() {
+          assertTrue(peoplePage.$$('#disconnectDialog').open);
+          assertFalse(!!peoplePage.$$('#deleteProfile'));
 
           var disconnectManagedProfileConfirm =
-              peoplePage.$.disconnectManagedProfileConfirm;
+              peoplePage.$$('#disconnectManagedProfileConfirm');
           assertTrue(!!disconnectManagedProfileConfirm);
           assertFalse(disconnectManagedProfileConfirm.hidden);
 
           browserProxy.resetResolver('signOut');
 
           var popstatePromise = new Promise(function(resolve) {
             listenOnce(window, 'popstate', resolve);
           });
 
           MockInteractions.tap(disconnectManagedProfileConfirm);
 
           return popstatePromise;
         }).then(function() {
           return browserProxy.whenCalled('signOut');
         }).then(function(deleteProfile) {
           assertTrue(deleteProfile);
         });
       });
 
       test('getProfileStatsCount', function() {
         return profileInfoBrowserProxy.whenCalled('getProfileStatsCount')
             .then(function() {
           Polymer.dom.flush();
 
           // Open the disconnect dialog.
           disconnectButton = peoplePage.$$('#disconnectButton');
           assertTrue(!!disconnectButton);
           MockInteractions.tap(disconnectButton);
-          Polymer.dom.flush();
 
-          assertTrue(peoplePage.$.disconnectDialog.open);
+          return new Promise(function(resolve) { peoplePage.async(resolve); });
+        }).then(function() {
+          assertTrue(peoplePage.$$('#disconnectDialog').open);
 
           // Assert the warning message is as expected.
           var warningMessage = peoplePage.$$('.delete-profile-warning');
 
           cr.webUIListenerCallback('profile-stats-count-ready', 0);
           assertEquals(
               loadTimeData.getStringF('deleteProfileWarningWithoutCounts',
                                       'fakeUsername'),
               warningMessage.textContent.trim());
 
           cr.webUIListenerCallback('profile-stats-count-ready', 1);
           assertEquals(
               loadTimeData.getStringF('deleteProfileWarningWithCountsSingular',
                                       'fakeUsername'),
               warningMessage.textContent.trim());
 
           cr.webUIListenerCallback('profile-stats-count-ready', 2);
           assertEquals(
               loadTimeData.getStringF('deleteProfileWarningWithCountsPlural', 2,
                                       'fakeUsername'),
               warningMessage.textContent.trim());
 
           // Close the disconnect dialog.
-          MockInteractions.tap(peoplePage.$.disconnectConfirm);
+          MockInteractions.tap(peoplePage.$$('#disconnectConfirm'));
           return new Promise(function(resolve) {
             listenOnce(window, 'popstate', resolve);
           });
         });
       });
 
       test('NavigateDirectlyToSignOutURL', function() {
         // Navigate to chrome://md-settings/signOut
         settings.navigateTo(settings.Route.SIGN_OUT);
-        Polymer.dom.flush();
 
-        assertTrue(peoplePage.$.disconnectDialog.open);
-
-        return profileInfoBrowserProxy.whenCalled('getProfileStatsCount')
-            .then(function() {
+        return new Promise(
+            function(resolve) { peoplePage.async(resolve); }).then(function() {
+          assertTrue(peoplePage.$$('#disconnectDialog').open);
+          return profileInfoBrowserProxy.whenCalled('getProfileStatsCount');
+        }).then(function() {
           // 'getProfileStatsCount' can be the first message sent to the handler
           // if the user navigates directly to chrome://md-settings/signOut. if
           // so, it should not cause a crash.
           new settings.ProfileInfoBrowserProxyImpl().getProfileStatsCount();
 
           // Close the disconnect dialog.
-          MockInteractions.tap(peoplePage.$.disconnectConfirm);
+          MockInteractions.tap(peoplePage.$$('#disconnectConfirm'));
+        }).then(function() {
           return new Promise(function(resolve) {
             listenOnce(window, 'popstate', resolve);
           });
         });
       });
 
       test('Signout dialog suppressed when not signed in', function() {
         return browserProxy.whenCalled('getSyncStatus').then(function() {
-          Polymer.dom.flush();
-
           settings.navigateTo(settings.Route.SIGN_OUT);
-          Polymer.dom.flush();
-
-          assertTrue(peoplePage.$.disconnectDialog.open);
+          return new Promise(function(resolve) { peoplePage.async(resolve); });
+        }).then(function() {
+          assertTrue(peoplePage.$$('#disconnectDialog').open);
 
           var popstatePromise = new Promise(function(resolve) {
             listenOnce(window, 'popstate', resolve);
           });
 
           cr.webUIListenerCallback('sync-status-changed', {
             signedIn: false,
           });
 
           return popstatePromise;
@@ skipping 84 matching lines @@
   }
 
   return {
     registerTests: function() {
       registerProfileInfoTests();
       if (!cr.isChromeOS)
         registerSyncStatusTests();
     },
   };
 });