Issue 2239943004: Follow-up fix for CL 2130093003 (format -> log_format)

Issue 2239943004: Follow-up fix for CL 2130093003 (format -> log_format) (Closed)

Created:
4 years, 4 months ago by qyearsley

Modified:
4 years, 4 months ago

Reviewers:
dnj, Dirk Pranke

CC:
blink-reviews, chromium-reviews, Dirk Pranke

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Follow-up fix for CL 2130093003 (format -> log_format) BUG=637384 Committed: https://crrev.com/faa9fe2108f48a8a31a44a5e4d75c632971b03ff Cr-Commit-Position: refs/heads/master@{#411795}

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 10 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239943004/1

4 years, 4 months ago (2016-08-12 21:10:30 UTC) #5

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/faa9fe2108f48a8a31a44a5e4d75c632971b03ff Cr-Commit-Position: refs/heads/master@{#411795}

4 years, 4 months ago (2016-08-12 22:22:31 UTC) #9

hiroshige

4 years, 4 months ago (2016-08-15 07:50:09 UTC) #10

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2244193002/ by hiroshige@chromium.org.

The reason for reverting is: https://codereview.chromium.org/2130093003 is
causing Linux ASAN bot failure:
crbug.com/637664
.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages