Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2239933003: Ensure that no scripts are resolved when compiling purely from deserialized data. (Closed)

Created:
4 years, 4 months ago by Johnni Winther
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure that no scripts are resolved when compiling purely from deserialized data. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/1a633236ea90c74b623fe9de47dcf63a538be7d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 2 chunks +14 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/options.dart View 4 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 4 months ago (2016-08-12 14:23:30 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 4 months ago (2016-08-12 16:00:51 UTC) #3
Johnni Winther
4 years, 4 months ago (2016-08-16 08:04:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a633236ea90c74b623fe9de47dcf63a538be7d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698