Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: pkg/compiler/lib/src/dart2js.dart

Issue 2239933003: Ensure that no scripts are resolved when compiling purely from deserialized data. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/dart2js.dart
diff --git a/pkg/compiler/lib/src/dart2js.dart b/pkg/compiler/lib/src/dart2js.dart
index 5efe438a18441a20729315b7ee99612afac14d85..ca6305ae243a25d749804ad30a9b8e9ef7d72c02 100644
--- a/pkg/compiler/lib/src/dart2js.dart
+++ b/pkg/compiler/lib/src/dart2js.dart
@@ -836,7 +836,8 @@ void _useSerializedDataForDartCore(CompileFunc oldCompileFunc) {
api.CompilerInput compilerInput,
api.CompilerDiagnostics compilerDiagnostics,
api.CompilerOutput compilerOutput,
- List<_SerializedData> serializedData) {
+ List<_SerializedData> serializedData,
+ {bool compileOnly: false}) {
api.CompilerInput input = compilerInput;
CompilerOptions options = compilerOptions;
if (serializedData != null && serializedData.isNotEmpty) {
@@ -854,7 +855,9 @@ void _useSerializedDataForDartCore(CompileFunc oldCompileFunc) {
}
}
options =
- CompilerOptions.copy(options, resolutionInputs: resolutionInputs);
+ CompilerOptions.copy(options,
+ resolutionInputs: resolutionInputs,
+ compileOnly: compileOnly);
}
return oldCompileFunc(options, input, compilerDiagnostics, compilerOutput);
}
@@ -905,7 +908,8 @@ void _useSerializedDataForDartCore(CompileFunc oldCompileFunc) {
compilerInput,
compilerDiagnostics,
compilerOutput,
- [serializedDartCore, output.serializedData]);
+ [serializedDartCore, output.serializedData],
+ compileOnly: true);
}
/// Compiles the entry point using the serialized data from dart:core.
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698