Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2239923004: [turbofan] The PlainPrimitiveToNumber operator cannot have side effects. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] The PlainPrimitiveToNumber operator cannot have side effects. An invocation of the ToNumber builtin resulting from lowering the PlainPrimitiveToNumber cannot have any observable side effects and thus the builtin call itself is eliminatable. R=yangguo@chromium.org Committed: https://crrev.com/63dd16849f5cf2b7c9c21dc073d6d470273b016c Cr-Commit-Position: refs/heads/master@{#38593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/compiler/effect-control-linearizer.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-12 04:34:18 UTC) #1
Yang
On 2016/08/12 04:34:18, Benedikt Meurer wrote: lgtm.
4 years, 4 months ago (2016-08-12 04:52:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239923004/1
4 years, 4 months ago (2016-08-12 04:52:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 05:08:27 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 05:08:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63dd16849f5cf2b7c9c21dc073d6d470273b016c
Cr-Commit-Position: refs/heads/master@{#38593}

Powered by Google App Engine
This is Rietveld 408576698