[turbofan] The PlainPrimitiveToNumber operator cannot have side effects.

src/compiler/effect-control-linearizer.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/effect-control-linearizer.h"
 
 #include "src/code-factory.h"
 #include "src/compiler/access-builder.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/linkage.h"
@@ skipping 2506 matching lines @@
 Node* EffectControlLinearizer::SmiShiftBitsConstant() {
   return jsgraph()->IntPtrConstant(kSmiShiftSize + kSmiTagSize);
 }
 
 EffectControlLinearizer::ValueEffectControl
 EffectControlLinearizer::LowerPlainPrimitiveToNumber(Node* node, Node* effect,
                                                      Node* control) {
   Node* value = node->InputAt(0);
   Node* result = effect =
       graph()->NewNode(ToNumberOperator(), jsgraph()->ToNumberBuiltinConstant(),
-                       value, jsgraph()->NoContextConstant(), effect, control);
+                       value, jsgraph()->NoContextConstant(), effect);
   return ValueEffectControl(result, effect, control);
 }
 
 EffectControlLinearizer::ValueEffectControl
 EffectControlLinearizer::LowerPlainPrimitiveToWord32(Node* node, Node* effect,
                                                      Node* control) {
   Node* value = node->InputAt(0);
 
   Node* check0 = ObjectIsSmi(value);
   Node* branch0 =
       graph()->NewNode(common()->Branch(BranchHint::kTrue), check0, control);
 
   Node* if_true0 = graph()->NewNode(common()->IfTrue(), branch0);
   Node* etrue0 = effect;
   Node* vtrue0 = ChangeSmiToInt32(value);
 
   Node* if_false0 = graph()->NewNode(common()->IfFalse(), branch0);
   Node* efalse0 = effect;
   Node* vfalse0;
   {
     vfalse0 = efalse0 = graph()->NewNode(
         ToNumberOperator(), jsgraph()->ToNumberBuiltinConstant(), value,
-        jsgraph()->NoContextConstant(), efalse0, if_false0);
+        jsgraph()->NoContextConstant(), efalse0);
 
     Node* check1 = ObjectIsSmi(vfalse0);
     Node* branch1 = graph()->NewNode(common()->Branch(), check1, if_false0);
 
     Node* if_true1 = graph()->NewNode(common()->IfTrue(), branch1);
     Node* etrue1 = efalse0;
     Node* vtrue1 = ChangeSmiToInt32(vfalse0);
 
     Node* if_false1 = graph()->NewNode(common()->IfFalse(), branch1);
     Node* efalse1 = efalse0;
@@ skipping 35 matching lines @@
     vtrue0 = ChangeSmiToInt32(value);
     vtrue0 = graph()->NewNode(machine()->ChangeInt32ToFloat64(), vtrue0);
   }
 
   Node* if_false0 = graph()->NewNode(common()->IfFalse(), branch0);
   Node* efalse0 = effect;
   Node* vfalse0;
   {
     vfalse0 = efalse0 = graph()->NewNode(
         ToNumberOperator(), jsgraph()->ToNumberBuiltinConstant(), value,
-        jsgraph()->NoContextConstant(), efalse0, if_false0);
+        jsgraph()->NoContextConstant(), efalse0);
 
     Node* check1 = ObjectIsSmi(vfalse0);
     Node* branch1 = graph()->NewNode(common()->Branch(), check1, if_false0);
 
     Node* if_true1 = graph()->NewNode(common()->IfTrue(), branch1);
     Node* etrue1 = efalse0;
     Node* vtrue1;
     {
       vtrue1 = ChangeSmiToInt32(vfalse0);
       vtrue1 = graph()->NewNode(machine()->ChangeInt32ToFloat64(), vtrue1);
@@ skipping 683 matching lines @@
 Isolate* EffectControlLinearizer::isolate() const {
   return jsgraph()->isolate();
 }
 
 Operator const* EffectControlLinearizer::ToNumberOperator() {
   if (!to_number_operator_.is_set()) {
     Callable callable = CodeFactory::ToNumber(isolate());
     CallDescriptor::Flags flags = CallDescriptor::kNoFlags;
     CallDescriptor* desc = Linkage::GetStubCallDescriptor(
         isolate(), graph()->zone(), callable.descriptor(), 0, flags,
-        Operator::kNoThrow);
+        Operator::kEliminatable);
     to_number_operator_.set(common()->Call(desc));
   }
   return to_number_operator_.get();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8