Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1461)

Issue 2239923002: Make blimp work on K (Closed)

Created:
4 years, 4 months ago by Menglin
Modified:
4 years, 4 months ago
Reviewers:
nyquist, no sievers
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, jam, gcasto+watch-blimp_chromium.org, rickyz+watch_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make blimp work on K The blimp engine is currently using Android M fonts, which works only with Android M clients. However, we need to make it work for K because currently clank only run layout tests on K devices. This CL adds a set of KTU84Z fonts to be used, ensure that they are part of the engine bundle, and update the documentation for where they are checked out, and how to use them in local engines. This also update client_engine_integration.py, so that the engine knows which system the client is on, and set the correct font path itself. When the zygote process starts, it looks at the android-fonts-path flag, It sets fonts.xml if the client is M, and sets system_fonts.xml & fallback_fonts.xml if the client is K. BUG=637117 Committed: https://crrev.com/20b549e660ff8420a8c400297a12779bb28c11ef Cr-Commit-Position: refs/heads/master@{#411768}

Patch Set 1 #

Total comments: 6

Patch Set 2 : nits and sync to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+442 lines, -219 lines) Patch
M blimp/docs/fonts.md View 1 chunk +0 lines, -3 lines 0 comments Download
M blimp/docs/running.md View 1 2 chunks +5 lines, -2 lines 0 comments Download
M blimp/tools/client_engine_integration.py View 1 4 chunks +10 lines, -3 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M third_party/blimp_fonts/BUILD.gn View 1 chunk +290 lines, -203 lines 0 comments Download
M third_party/blimp_fonts/LICENSE View 1 5 chunks +115 lines, -2 lines 0 comments Download
M third_party/blimp_fonts/README.chromium View 2 chunks +9 lines, -3 lines 0 comments Download
M third_party/blimp_fonts/font_bundle.tar.gz.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Menglin
sievers@chromium.org: Please review changes in content/zygote/zygote_main_linux.cc nyquist@chromium.org: Please review changes in the other files
4 years, 4 months ago (2016-08-11 22:37:32 UTC) #2
nyquist
blimp and third_party/blimp_font lgtm https://codereview.chromium.org/2239923002/diff/1/blimp/docs/running.md File blimp/docs/running.md (right): https://codereview.chromium.org/2239923002/diff/1/blimp/docs/running.md#newcode166 blimp/docs/running.md:166: If the android client is ...
4 years, 4 months ago (2016-08-12 03:44:12 UTC) #3
no sievers
content lgtm
4 years, 4 months ago (2016-08-12 17:15:40 UTC) #4
Menglin
https://codereview.chromium.org/2239923002/diff/1/blimp/docs/running.md File blimp/docs/running.md (right): https://codereview.chromium.org/2239923002/diff/1/blimp/docs/running.md#newcode166 blimp/docs/running.md:166: If the android client is kitkat system, this would ...
4 years, 4 months ago (2016-08-12 19:25:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239923002/20001
4 years, 4 months ago (2016-08-12 19:26:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 21:13:21 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 21:21:10 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20b549e660ff8420a8c400297a12779bb28c11ef
Cr-Commit-Position: refs/heads/master@{#411768}

Powered by Google App Engine
This is Rietveld 408576698