Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2239863002: Remove some unnecessary refcount increments in WebCrypto's EC code. (Closed)

Created:
4 years, 4 months ago by eroman
Modified:
4 years, 4 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ec_raw
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some unnecessary refcount increments in WebCrypto's EC code. Committed: https://crrev.com/aea7dbff989b27e77ab490a2edb0347e2dac6ee6 Cr-Commit-Position: refs/heads/master@{#411501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M components/webcrypto/algorithms/ec.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M components/webcrypto/algorithms/ecdh.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M components/webcrypto/algorithms/ecdsa.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
eroman
4 years, 4 months ago (2016-08-11 21:08:40 UTC) #3
davidben
lgtm
4 years, 4 months ago (2016-08-11 22:43:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239863002/1
4 years, 4 months ago (2016-08-12 01:00:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 01:06:27 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 01:09:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aea7dbff989b27e77ab490a2edb0347e2dac6ee6
Cr-Commit-Position: refs/heads/master@{#411501}

Powered by Google App Engine
This is Rietveld 408576698