[webcrypto] Add support for import/export of "raw" formatted EC keys.

[webcrypto] Add support for import/export of "raw" formatted EC keys.

BUG=437576
Committed: https://crrev.com/cfcb6c9fda6465b5c12ca3d71f8e13b07e233abd
Cr-Commit-Position: refs/heads/master@{#411480}

[eroman, 2016-07-20 02:38:52]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 02:39:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 04:17:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 04:17:51]

Dry run: This issue passed the CQ dry run.

[eroman, 2016-07-20 05:14:29]

eroman@chromium.org changed reviewers:
+ rsleevi@chromium.org

[eroman, 2016-08-03 01:50:54]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 01:51:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 03:52:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 03:52:20]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[eroman, 2016-08-03 17:09:06]

https://codereview.chromium.org/2162303002/diff/40001/components/webcrypto/al...
File components/webcrypto/algorithms/ec.cc (right):

https://codereview.chromium.org/2162303002/diff/40001/components/webcrypto/al...
components/webcrypto/algorithms/ec.cc:338: Status status =
CheckKeyCreationUsages(all_public_key_usages_, usages);
For the record, technically this is a deviation from the spec, but that is
clearly just a spec bug:
https://github.com/w3c/webcrypto/issues/130

https://codereview.chromium.org/2162303002/diff/40001/components/webcrypto/al...
components/webcrypto/algorithms/ec.cc:560: // Serialize the public key as an
uncompressed point in X9.62 form.
For the record, this is an interpretation on my part. The spec doesn't say what
form of encoding to use:
https://github.com/w3c/webcrypto/issues/129

However uncompressed is the most reasonable choice, and is also the form that
Firefox uses.

[eroman, 2016-08-03 17:09:15]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 17:09:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 18:41:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 18:41:34]

Dry run: This issue passed the CQ dry run.

[eroman, 2016-08-10 21:11:52]

ping

[Ryan Sleevi, 2016-08-11 19:47:06]

rsleevi@chromium.org changed reviewers:
+ davidben@chromium.org

[Ryan Sleevi, 2016-08-11 19:47:07]

LGTM, if David can double check the specific point manipulation for BoringSSL

https://codereview.chromium.org/2162303002/diff/40001/components/webcrypto/al...
File components/webcrypto/algorithms/ec.cc (right):

https://codereview.chromium.org/2162303002/diff/40001/components/webcrypto/al...
components/webcrypto/algorithms/ec.cc:357: key_data.bytes(),
key_data.byte_length(), NULL)) {
pedantry: nullptr?

[davidben, 2016-08-11 19:51:30]

BoringSSL bits lgtm

https://codereview.chromium.org/2162303002/diff/40001/components/webcrypto/al...
File components/webcrypto/algorithms/ec.cc (right):

https://codereview.chromium.org/2162303002/diff/40001/components/webcrypto/al...
components/webcrypto/algorithms/ec.cc:371: if (!pkey ||
!EVP_PKEY_set1_EC_KEY(pkey.get(), ec.get()))
[We really should make EVP_PKEY_new_EC_KEY functions and friends...]

https://codereview.chromium.org/2162303002/diff/40001/components/webcrypto/al...
components/webcrypto/algorithms/ec.cc:556: crypto::ScopedEC_KEY
ec(EVP_PKEY_get1_EC_KEY(pkey));
There's also EVP_PKEY_get0_EC_KEY which does the same thing but avoids needing
to bounce on a refcount.

[eroman, 2016-08-11 21:00:53]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[eroman, 2016-08-11 21:01:09]

Thanks for the review!

https://codereview.chromium.org/2162303002/diff/40001/components/webcrypto/al...
File components/webcrypto/algorithms/ec.cc (right):

https://codereview.chromium.org/2162303002/diff/40001/components/webcrypto/al...
components/webcrypto/algorithms/ec.cc:357: key_data.bytes(),
key_data.byte_length(), NULL)) {
On 2016/08/11 19:47:07, Ryan Sleevi (slow) wrote:
> pedantry: nullptr?

Done.

https://codereview.chromium.org/2162303002/diff/40001/components/webcrypto/al...
components/webcrypto/algorithms/ec.cc:371: if (!pkey ||
!EVP_PKEY_set1_EC_KEY(pkey.get(), ec.get()))
On 2016/08/11 19:51:30, davidben wrote:
> [We really should make EVP_PKEY_new_EC_KEY functions and friends...]

Acknowledged.

https://codereview.chromium.org/2162303002/diff/40001/components/webcrypto/al...
components/webcrypto/algorithms/ec.cc:556: crypto::ScopedEC_KEY
ec(EVP_PKEY_get1_EC_KEY(pkey));
On 2016/08/11 19:51:30, davidben wrote:
> There's also EVP_PKEY_get0_EC_KEY which does the same thing but avoids needing
> to bounce on a refcount.

Done.

[commit-bot: I haz the power, 2016-08-11 21:01:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2016-08-11 22:12:42]

The CQ bit was unchecked by eroman@chromium.org

[eroman, 2016-08-11 22:12:47]

The CQ bit was checked by eroman@chromium.org

[eroman, 2016-08-11 22:12:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
rsleevi@chromium.org, davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/2162303002/#ps80001
(title: "address feedback")

[commit-bot: I haz the power, 2016-08-11 22:13:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 00:34:03]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-12 00:35:24]

Description was changed from

==========
[webcrypto] Add support for import/export of "raw" formatted EC keys.

BUG=437576
==========

to

==========
[webcrypto] Add support for import/export of "raw" formatted EC keys.

BUG=437576

Committed: https://crrev.com/cfcb6c9fda6465b5c12ca3d71f8e13b07e233abd
Cr-Commit-Position: refs/heads/master@{#411480}
==========

[commit-bot: I haz the power, 2016-08-12 00:35:25]

Patchset 5 (id:??) landed as
https://crrev.com/cfcb6c9fda6465b5c12ca3d71f8e13b07e233abd
Cr-Commit-Position: refs/heads/master@{#411480}