[compiler] Allow matcher to work on arch without scaling capability

[compiler] Allow matcher to work on arch without scaling capability

Add an extra paramter to disable scale on BaseWithIndexAndDisplacementMatcher.

R=bmeurer@chromium.org, epertoso@chromium.org, jarin@chromium.org, mstarzinger@chromium.org, mtrofin@chromium.org, titzer@chromium.org
BUG=

Committed: https://crrev.com/cba03ba85ff8df72ee433f5ab6ab841a5b76cb31
Cr-Commit-Position: refs/heads/master@{#38635}

[john.yan, 2016-08-11 19:18:26]

PTAL

[Benedikt Meurer, 2016-08-12 17:57:06]

https://codereview.chromium.org/2239813002/diff/1/src/compiler/node-matchers.h
File src/compiler/node-matchers.h (right):

https://codereview.chromium.org/2239813002/diff/1/src/compiler/node-matchers....
src/compiler/node-matchers.h:399: BaseWithIndexAndDisplacementMatcher(Node*
node, bool allow_input_swap,
Can you turn these two booleans into flags? Using an enum (class) + base::Flags?

[john.yan, 2016-08-14 22:24:54]

On 2016/08/12 17:57:06, Benedikt Meurer wrote:
> https://codereview.chromium.org/2239813002/diff/1/src/compiler/node-matchers.h
> File src/compiler/node-matchers.h (right):
> 
>
https://codereview.chromium.org/2239813002/diff/1/src/compiler/node-matchers....
> src/compiler/node-matchers.h:399: BaseWithIndexAndDisplacementMatcher(Node*
> node, bool allow_input_swap,
> Can you turn these two booleans into flags? Using an enum (class) +
base::Flags?

Updated as suggested. Thanks.

[john.yan, 2016-08-14 22:28:00]

The CQ bit was checked by jyan@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-14 22:28:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-14 22:50:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-14 22:50:11]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-08-15 06:29:20]

LGTM once comment addressed.

https://codereview.chromium.org/2239813002/diff/20001/src/compiler/node-match...
File src/compiler/node-matchers.h (right):

https://codereview.chromium.org/2239813002/diff/20001/src/compiler/node-match...
src/compiler/node-matchers.h:397: template <class AddMatcher>
You need to move this enum out of the template class add add
DEFINE_OPERATORS_FOR_FLAGS for the flags as well, i.e.

enum class DisplacementFlag : uint8_t {
...
};
typedef base::Flags<DisplacementFlag, uint8_t> DisplacementFlags;
DEFINE_OPERATORS_FOR_FLAGS(DisplacementFlags);

[john.yan, 2016-08-15 14:13:33]

On 2016/08/15 06:29:20, Benedikt Meurer wrote:
> LGTM once comment addressed.
> 
>
https://codereview.chromium.org/2239813002/diff/20001/src/compiler/node-match...
> File src/compiler/node-matchers.h (right):
> 
>
https://codereview.chromium.org/2239813002/diff/20001/src/compiler/node-match...
> src/compiler/node-matchers.h:397: template <class AddMatcher>
> You need to move this enum out of the template class add add
> DEFINE_OPERATORS_FOR_FLAGS for the flags as well, i.e.
> 
> enum class DisplacementFlag : uint8_t {
> ...
> };
> typedef base::Flags<DisplacementFlag, uint8_t> DisplacementFlags;
> DEFINE_OPERATORS_FOR_FLAGS(DisplacementFlags);

Thank you Benedikt. It's been updated as suggested.

[john.yan, 2016-08-15 14:15:09]

The CQ bit was checked by jyan@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 14:15:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 14:36:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 14:36:30]

Dry run: This issue passed the CQ dry run.

[john.yan, 2016-08-15 14:39:05]

The CQ bit was unchecked by jyan@ca.ibm.com

[john.yan, 2016-08-15 14:39:15]

The CQ bit was checked by jyan@ca.ibm.com

[john.yan, 2016-08-15 14:39:15]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2239813002/#ps40001
(title: "Move out of Matcher template")

[commit-bot: I haz the power, 2016-08-15 14:39:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 14:41:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-15 14:41:27]

Description was changed from

==========
[compiler] Allow matcher to work on arch without scaling capability

Add an extra paramter to disable scale on BaseWithIndexAndDisplacementMatcher.

R=bmeurer@chromium.org, epertoso@chromium.org, jarin@chromium.org,
mstarzinger@chromium.org, mtrofin@chromium.org, titzer@chromium.org
BUG=
==========

to

==========
[compiler] Allow matcher to work on arch without scaling capability

Add an extra paramter to disable scale on BaseWithIndexAndDisplacementMatcher.

R=bmeurer@chromium.org, epertoso@chromium.org, jarin@chromium.org,
mstarzinger@chromium.org, mtrofin@chromium.org, titzer@chromium.org
BUG=

Committed: https://crrev.com/cba03ba85ff8df72ee433f5ab6ab841a5b76cb31
Cr-Commit-Position: refs/heads/master@{#38635}
==========

[commit-bot: I haz the power, 2016-08-15 14:41:28]

Patchset 3 (id:??) landed as
https://crrev.com/cba03ba85ff8df72ee433f5ab6ab841a5b76cb31
Cr-Commit-Position: refs/heads/master@{#38635}