Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: src/compiler/node-matchers.h

Issue 2239813002: [compiler] Allow matcher to work on arch without scaling capability (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Move out of Matcher template Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/ia32/instruction-selector-ia32.cc ('k') | src/compiler/ppc/instruction-selector-ppc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/node-matchers.h
diff --git a/src/compiler/node-matchers.h b/src/compiler/node-matchers.h
index 19089c5d6c4219fc085e37547f7fd69980f73273..10aed51a578877b93ea595a275a0e0657b512729 100644
--- a/src/compiler/node-matchers.h
+++ b/src/compiler/node-matchers.h
@@ -394,16 +394,26 @@ typedef AddMatcher<Int64BinopMatcher, IrOpcode::kInt64Add, IrOpcode::kInt64Sub,
enum DisplacementMode { kPositiveDisplacement, kNegativeDisplacement };
+enum class AddressOption : uint8_t {
+ kAllowNone = 0u,
+ kAllowInputSwap = 1u << 0,
+ kAllowScale = 1u << 1,
+ kAllowAll = kAllowInputSwap | kAllowScale
+};
+
+typedef base::Flags<AddressOption, uint8_t> AddressOptions;
+DEFINE_OPERATORS_FOR_FLAGS(AddressOptions);
+
template <class AddMatcher>
struct BaseWithIndexAndDisplacementMatcher {
- BaseWithIndexAndDisplacementMatcher(Node* node, bool allow_input_swap)
+ BaseWithIndexAndDisplacementMatcher(Node* node, AddressOptions options)
: matches_(false),
index_(nullptr),
scale_(0),
base_(nullptr),
displacement_(nullptr),
displacement_mode_(kPositiveDisplacement) {
- Initialize(node, allow_input_swap);
+ Initialize(node, options);
}
explicit BaseWithIndexAndDisplacementMatcher(Node* node)
@@ -413,7 +423,10 @@ struct BaseWithIndexAndDisplacementMatcher {
base_(nullptr),
displacement_(nullptr),
displacement_mode_(kPositiveDisplacement) {
- Initialize(node, node->op()->HasProperty(Operator::kCommutative));
+ Initialize(node, AddressOption::kAllowScale |
+ (node->op()->HasProperty(Operator::kCommutative)
+ ? AddressOption::kAllowInputSwap
+ : AddressOption::kAllowNone));
}
bool matches() const { return matches_; }
@@ -431,7 +444,7 @@ struct BaseWithIndexAndDisplacementMatcher {
Node* displacement_;
DisplacementMode displacement_mode_;
- void Initialize(Node* node, bool allow_input_swap) {
+ void Initialize(Node* node, AddressOptions options) {
// The BaseWithIndexAndDisplacementMatcher canonicalizes the order of
// displacements and scale factors that are used as inputs, so instead of
// enumerating all possible patterns by brute force, checking for node
@@ -449,7 +462,7 @@ struct BaseWithIndexAndDisplacementMatcher {
// (B + D)
// (B + B)
if (node->InputCount() < 2) return;
- AddMatcher m(node, allow_input_swap);
+ AddMatcher m(node, options & AddressOption::kAllowInputSwap);
Node* left = m.left().node();
Node* right = m.right().node();
Node* displacement = nullptr;
@@ -608,6 +621,10 @@ struct BaseWithIndexAndDisplacementMatcher {
base = index;
}
}
+ if (!(options & AddressOption::kAllowScale) && scale != 0) {
+ index = scale_expression;
+ scale = 0;
+ }
base_ = base;
displacement_ = displacement;
displacement_mode_ = displacement_mode;
« no previous file with comments | « src/compiler/ia32/instruction-selector-ia32.cc ('k') | src/compiler/ppc/instruction-selector-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698