ios/public/provider/chrome/browser/chrome_browser_provider.h - Issue 2239773002: Annotates functions returning retained objects.

Unified Diff: ios/public/provider/chrome/browser/chrome_browser_provider.h

Issue 2239773002: Annotates functions returning retained objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removes functions that are not in headers AND not in ios code. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/public/provider/chrome/browser/chrome_browser_provider.h

diff --git a/ios/public/provider/chrome/browser/chrome_browser_provider.h b/ios/public/provider/chrome/browser/chrome_browser_provider.h

index 27ed5e195f30e5410fe5066c97fa77473f4c6dfc..962f82f1a2ec5ce223a02565edd8cca4b4425a55 100644

--- a/ios/public/provider/chrome/browser/chrome_browser_provider.h

+++ b/ios/public/provider/chrome/browser/chrome_browser_provider.h

@@ -6,6 +6,7 @@

#define IOS_PUBLIC_PROVIDER_CHROME_BROWSER_CHROME_BROWSER_PROVIDER_H_

#include <CoreGraphics/CoreGraphics.h>

+#import <Foundation/NSObjCRuntime.h>

Eugene But (OOO till 7-30) 2016/08/16 16:45:48 Please import <Foundation/Foundation.h> instead:

stkhapugin 2016/08/18 12:54:19 Done.

#include <stddef.h>

#include <memory>

@@ -76,7 +77,7 @@ class ChromeBrowserProvider {

// object is retained.

virtual InfoBarViewPlaceholder CreateInfoBarView(

CGRect frame,

- InfoBarViewDelegate* delegate);

+ InfoBarViewDelegate* delegate) NS_RETURNS_RETAINED;

Eugene But (OOO till 7-30) 2016/08/16 16:45:48 C++ Style Guide recommends to avoid returning unow

stkhapugin 2016/08/16 16:51:49 I would argue that all of these {C++ methods|C fun

// Returns an instance of a signin resources provider.

virtual SigninResourcesProvider* GetSigninResourcesProvider();

// Returns an instance of a Chrome identity service.