Annotates functions returning retained objects.

ios/public/provider/chrome/browser/chrome_browser_provider.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_PUBLIC_PROVIDER_CHROME_BROWSER_CHROME_BROWSER_PROVIDER_H_
 #define IOS_PUBLIC_PROVIDER_CHROME_BROWSER_CHROME_BROWSER_PROVIDER_H_
 
 #include <CoreGraphics/CoreGraphics.h>
+#import <Foundation/NSObjCRuntime.h>

[Eugene But (OOO till 7-30), 2016/08/16 16:45:48]

Please import <Foundation/Foundation.h> instead:

go/objc-style?showone=Use_Umbrella_Frameworks&cl=head#Use_Umbrella_Frameworks

[stkhapugin, 2016/08/18 12:54:19]

Done.

 #include <stddef.h>
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/callback_forward.h"
 #include "base/memory/ref_counted.h"
 #include "components/favicon_base/favicon_callback.h"
 
@@ skipping 50 matching lines @@
   virtual void AssertBrowserContextKeyedFactoriesBuilt();
   // Registers all prefs that will be used via a PrefService attached to a
   // Profile.
   virtual void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
   // Returns an UpdatableResourceProvider instance.
   virtual UpdatableResourceProvider* GetUpdatableResourceProvider();
   // Returns an infobar view conforming to the InfoBarViewProtocol. The returned
   // object is retained.
   virtual InfoBarViewPlaceholder CreateInfoBarView(
       CGRect frame,
-      InfoBarViewDelegate* delegate);
+      InfoBarViewDelegate* delegate) NS_RETURNS_RETAINED;

[Eugene But (OOO till 7-30), 2016/08/16 16:45:48]

C++ Style Guide recommends to avoid returning unowned pointers:
https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#...

Should this return autoreleased object instead? Same question for all methods
which return retained object.

[stkhapugin, 2016/08/16 16:51:49]

I would argue that all of these {C++ methods|C functions} should be returning
autoreleased objects instead. However, this annotation is a quick fix, it can be
easily searched for later, and if everyone agrees that moving forward we want
all functions to return autoreleased objects, we can fix it later. 

Rohit, what do you think?

   // Returns an instance of a signin resources provider.
   virtual SigninResourcesProvider* GetSigninResourcesProvider();
   // Returns an instance of a Chrome identity service.
   virtual ChromeIdentityService* GetChromeIdentityService();
   // Returns an instance of a LiveTabContextProvider.
   virtual LiveTabContextProvider* GetLiveTabContextProvider();
   virtual GeolocationUpdaterProvider* GetGeolocationUpdaterProvider();
   // Returns "enabled", "disabled", or "default".
   virtual std::string DataReductionProxyAvailability();
   // Returns the distribution brand code.
@@ skipping 21 matching lines @@
   virtual bool IsSafeBrowsingEnabled(const base::Closure& on_update_callback);
 
   // Returns the SyncedWindowDelegatesGetter implementation.
   virtual std::unique_ptr<browser_sync::SyncedWindowDelegatesGetter>
   CreateSyncedWindowDelegatesGetter(ios::ChromeBrowserState* browser_state);
 };
 
 }  // namespace ios
 
 #endif  // IOS_PUBLIC_PROVIDER_CHROME_BROWSER_CHROME_BROWSER_PROVIDER_H_