Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2239743002: Re-enable flaky tests (Closed)

Created:
4 years, 4 months ago by kapishnikov
Modified:
4 years, 4 months ago
Reviewers:
mgersh, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable flaky tests Re-enable flaky tests that were disabled in March to see if they are still flaky and collect logs (the old logs have been deleted already). Re-enabled tests: CronetUrlRequestContextTest#testShutdownAfterError CronetUrlRequestContextTest#testShutdown CronetUrlRequestTest#testFailures BUG=635025, 635026, 596929 Committed: https://crrev.com/772024836ca4c86c35176d5146359f67ee12077a Cr-Commit-Position: refs/heads/master@{#411347}

Patch Set 1 #

Patch Set 2 : Re-enabled CronetUrlRequestContextTest#testShutdown #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 1 3 chunks +0 lines, -10 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
kapishnikov
4 years, 4 months ago (2016-08-11 15:07:22 UTC) #2
mgersh
lgtm. There's also CronetUrlRequestContextTest#testShutdown, which you can steal from me if you want, otherwise I'll ...
4 years, 4 months ago (2016-08-11 15:09:30 UTC) #3
xunjieli
lgtm! Thanks for taking this on, Andrei!
4 years, 4 months ago (2016-08-11 15:10:25 UTC) #4
kapishnikov
On 2016/08/11 15:09:30, mgersh wrote: > lgtm. There's also CronetUrlRequestContextTest#testShutdown, which you can steal > ...
4 years, 4 months ago (2016-08-11 15:17:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239743002/20001
4 years, 4 months ago (2016-08-11 15:41:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 16:19:19 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 16:21:00 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/772024836ca4c86c35176d5146359f67ee12077a
Cr-Commit-Position: refs/heads/master@{#411347}

Powered by Google App Engine
This is Rietveld 408576698