Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 2239743002: Re-enable flaky tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re-enabled CronetUrlRequestContextTest#testShutdown Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.net; 5 package org.chromium.net;
6 6
7 import android.content.Context; 7 import android.content.Context;
8 import android.content.ContextWrapper; 8 import android.content.ContextWrapper;
9 import android.os.ConditionVariable; 9 import android.os.ConditionVariable;
10 import android.os.Handler; 10 import android.os.Handler;
11 import android.os.Looper; 11 import android.os.Looper;
12 import android.os.StrictMode; 12 import android.os.StrictMode;
13 import android.test.suitebuilder.annotation.SmallTest; 13 import android.test.suitebuilder.annotation.SmallTest;
14 14
15 import org.chromium.base.PathUtils; 15 import org.chromium.base.PathUtils;
16 import org.chromium.base.annotations.JNINamespace; 16 import org.chromium.base.annotations.JNINamespace;
17 import org.chromium.base.test.util.Feature; 17 import org.chromium.base.test.util.Feature;
18 import org.chromium.base.test.util.FlakyTest;
19 import org.chromium.net.TestUrlRequestCallback.ResponseStep; 18 import org.chromium.net.TestUrlRequestCallback.ResponseStep;
20 import org.chromium.net.impl.CronetLibraryLoader; 19 import org.chromium.net.impl.CronetLibraryLoader;
21 import org.chromium.net.impl.CronetUrlRequestContext; 20 import org.chromium.net.impl.CronetUrlRequestContext;
22 import org.chromium.net.test.EmbeddedTestServer; 21 import org.chromium.net.test.EmbeddedTestServer;
23 22
24 import java.io.BufferedReader; 23 import java.io.BufferedReader;
25 import java.io.File; 24 import java.io.File;
26 import java.io.FileReader; 25 import java.io.FileReader;
27 import java.util.Arrays; 26 import java.util.Arrays;
28 import java.util.LinkedList; 27 import java.util.LinkedList;
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 // NETWORK_QUALITY_OBSERVATION_SOURCE_QUIC 321 // NETWORK_QUALITY_OBSERVATION_SOURCE_QUIC
323 assertEquals(0, rttListener.rttObservationCount(2)); 322 assertEquals(0, rttListener.rttObservationCount(2));
324 323
325 // Verify that the listeners were notified on the expected thread. 324 // Verify that the listeners were notified on the expected thread.
326 assertEquals(mNetworkQualityThread, rttListener.getThread()); 325 assertEquals(mNetworkQualityThread, rttListener.getThread());
327 assertEquals(mNetworkQualityThread, throughputListener.getThread()); 326 assertEquals(mNetworkQualityThread, throughputListener.getThread());
328 327
329 mTestFramework.mCronetEngine.shutdown(); 328 mTestFramework.mCronetEngine.shutdown();
330 } 329 }
331 330
332
333
334 /**
335 @SmallTest 331 @SmallTest
336 @Feature({"Cronet"}) 332 @Feature({"Cronet"})
337 https://crbug.com/596929
338 */
339 @FlakyTest
340 public void testShutdown() throws Exception { 333 public void testShutdown() throws Exception {
341 mTestFramework = startCronetTestFramework(); 334 mTestFramework = startCronetTestFramework();
342 TestUrlRequestCallback callback = new ShutdownTestUrlRequestCallback(); 335 TestUrlRequestCallback callback = new ShutdownTestUrlRequestCallback();
343 // Block callback when response starts to verify that shutdown fails 336 // Block callback when response starts to verify that shutdown fails
344 // if there are active requests. 337 // if there are active requests.
345 callback.setAutoAdvance(false); 338 callback.setAutoAdvance(false);
346 UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder( 339 UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(
347 mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEn gine); 340 mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEn gine);
348 UrlRequest urlRequest = urlRequestBuilder.build(); 341 UrlRequest urlRequest = urlRequestBuilder.build();
349 urlRequest.start(); 342 urlRequest.start();
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 mTestFramework = startCronetTestFramework(); 451 mTestFramework = startCronetTestFramework();
459 try { 452 try {
460 mTestFramework.mCronetEngine.shutdown(); 453 mTestFramework.mCronetEngine.shutdown();
461 mTestFramework.mCronetEngine.shutdown(); 454 mTestFramework.mCronetEngine.shutdown();
462 fail("Should throw an exception"); 455 fail("Should throw an exception");
463 } catch (Exception e) { 456 } catch (Exception e) {
464 assertEquals("Engine is shut down.", e.getMessage()); 457 assertEquals("Engine is shut down.", e.getMessage());
465 } 458 }
466 } 459 }
467 460
468 /*
469 @SmallTest 461 @SmallTest
470 @Feature({"Cronet"}) 462 @Feature({"Cronet"})
471 */
472 @FlakyTest(message = "https://crbug.com/592444")
473 public void testShutdownAfterError() throws Exception { 463 public void testShutdownAfterError() throws Exception {
474 mTestFramework = startCronetTestFramework(); 464 mTestFramework = startCronetTestFramework();
475 TestUrlRequestCallback callback = new ShutdownTestUrlRequestCallback(); 465 TestUrlRequestCallback callback = new ShutdownTestUrlRequestCallback();
476 UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(MOCK_CRONE T_TEST_FAILED_URL, 466 UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(MOCK_CRONE T_TEST_FAILED_URL,
477 callback, callback.getExecutor(), mTestFramework.mCronetEngine); 467 callback, callback.getExecutor(), mTestFramework.mCronetEngine);
478 urlRequestBuilder.build().start(); 468 urlRequestBuilder.build().start();
479 callback.blockForDone(); 469 callback.blockForDone();
480 assertTrue(callback.mOnErrorCalled); 470 assertTrue(callback.mOnErrorCalled);
481 } 471 }
482 472
(...skipping 630 matching lines...) Expand 10 before | Expand all | Expand 10 after
1113 } 1103 }
1114 }.start(); 1104 }.start();
1115 otherThreadDone.block(); 1105 otherThreadDone.block();
1116 builder.build().shutdown(); 1106 builder.build().shutdown();
1117 uiThreadDone.open(); 1107 uiThreadDone.open();
1118 } 1108 }
1119 }); 1109 });
1120 assertTrue(uiThreadDone.block(1000)); 1110 assertTrue(uiThreadDone.block(1000));
1121 } 1111 }
1122 } 1112 }
OLDNEW
« no previous file with comments | « no previous file | components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698