ImageCapture: support enhanced FocusMode getting/setting

ImageCapture: support enhanced FocusMode getting/setting

This CL provides support for FocusMode getting/setting
for the ImageCapture API. In particular:

- FocusMode used to be boolean-like (manual/auto), but
is changed to an enum throughout: "manual", "single-shot"
and "continuous", which better reflects the hardware modes.

- WebKit parts and LayoutTest updated.

- support for setting Focus is added, which forces to
 beef up the java setPhotoOptions() method. This is turn
 makes possible to bring the options |width| and |height|
 into it, and out of takePhoto(). (and that allows for them
 being removed from VCDAndroid class).

- setting FocusMode to single-shot must trigger a focus
sweep, and usually is done in AUTO mode.

BUG=518807
TEST=extensively in a N7.2, N6, N5x with
https://rawgit.com/Miguelao/demos/master/imagecapture.html

Committed: https://crrev.com/900fd602c52a2bd986c7230a2fdfacba3294db7c
Cr-Commit-Position: refs/heads/master@{#412156}

[mcasas, 2016-08-12 22:57:39]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-08-12 22:57:45]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-08-13 00:17:15]

Patchset #1 (id:40001) has been deleted

[mcasas, 2016-08-13 00:17:20]

Patchset #1 (id:60001) has been deleted

[mcasas, 2016-08-13 01:29:59]

Description was changed from

==========
[wip] ImageCapture: focus

BUG=518807
==========

to

==========
ImageCapture: support enhanced FocusMode getting/setting

This CL provides support for FocusMode getting/setting
for the ImageCapture API. In particular:

- FocusMode used to be boolean-like (manual/auto), but 
is changed to an enum throughout: "manual", "single-shot"
and "continuous", which better reflects the hardware modes.

- WebKit parts and LayoutTest updated.

- support for setting Focus is added, which forces to
 beef up the java setPhotoOptions() method. This is turn
 makes possible to bring the options |width| and |height|
 into it, and out of takePhoto(). (and that allows for them
 being removed from VCDAndroid class).

- setting FocusMode to single-shot must trigger a focus
sweep, and usually is done in AUTO mode.

BUG=518807
TEST=extensively in a N7,.2, N6, N5x with
https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

[mcasas, 2016-08-13 01:31:28]

Description was changed from

==========
ImageCapture: support enhanced FocusMode getting/setting

This CL provides support for FocusMode getting/setting
for the ImageCapture API. In particular:

- FocusMode used to be boolean-like (manual/auto), but 
is changed to an enum throughout: "manual", "single-shot"
and "continuous", which better reflects the hardware modes.

- WebKit parts and LayoutTest updated.

- support for setting Focus is added, which forces to
 beef up the java setPhotoOptions() method. This is turn
 makes possible to bring the options |width| and |height|
 into it, and out of takePhoto(). (and that allows for them
 being removed from VCDAndroid class).

- setting FocusMode to single-shot must trigger a focus
sweep, and usually is done in AUTO mode.

BUG=518807
TEST=extensively in a N7,.2, N6, N5x with
https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

to

==========
ImageCapture: support enhanced FocusMode getting/setting

This CL provides support for FocusMode getting/setting
for the ImageCapture API. In particular:

- FocusMode used to be boolean-like (manual/auto), but 
is changed to an enum throughout: "manual", "single-shot"
and "continuous", which better reflects the hardware modes.

- WebKit parts and LayoutTest updated.

- support for setting Focus is added, which forces to
 beef up the java setPhotoOptions() method. This is turn
 makes possible to bring the options |width| and |height|
 into it, and out of takePhoto(). (and that allows for them
 being removed from VCDAndroid class).

- setting FocusMode to single-shot must trigger a focus
sweep, and usually is done in AUTO mode.

BUG=518807
TEST=extensively in a N7.2, N6, N5x with
https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

[mcasas, 2016-08-13 01:46:38]

mcasas@chromium.org changed reviewers:
+ qinmin@chromium.org, reillyg@chromium.org

[mcasas, 2016-08-13 01:46:38]

reillyg@ PTAL at C++ parts

qinmin@ PTAL at Java parts.

[Reilly Grant (use Gerrit), 2016-08-15 20:28:18]

C++ lgtm

https://codereview.chromium.org/2239583002/diff/80001/media/capture/video/and...
File media/capture/video/android/photo_capabilities.h (right):

https://codereview.chromium.org/2239583002/diff/80001/media/capture/video/and...
media/capture/video/android/photo_capabilities.h:17: // Blabla?
?

https://codereview.chromium.org/2239583002/diff/80001/media/capture/video/and...
File media/capture/video/android/video_capture_device_android.cc (right):

https://codereview.chromium.org/2239583002/diff/80001/media/capture/video/and...
media/capture/video/android/video_capture_device_android.cc:449: default:
Use an enum class and you won't need a default case.

[qinmin, 2016-08-15 20:49:07]

lgtm

[mcasas, 2016-08-15 21:08:53]

mcasas@chromium.org changed reviewers:
+ tsepez@chromium.org

[mcasas, 2016-08-15 21:08:54]

tsepez@ media/mojo/interfaces/image_capture.mojom plz

https://codereview.chromium.org/2239583002/diff/80001/media/capture/video/and...
File media/capture/video/android/photo_capabilities.h (right):

https://codereview.chromium.org/2239583002/diff/80001/media/capture/video/and...
media/capture/video/android/photo_capabilities.h:17: // Blabla?
On 2016/08/15 20:28:18, Reilly Grant wrote:
> ?

Oops, done.

https://codereview.chromium.org/2239583002/diff/80001/media/capture/video/and...
File media/capture/video/android/video_capture_device_android.cc (right):

https://codereview.chromium.org/2239583002/diff/80001/media/capture/video/and...
media/capture/video/android/video_capture_device_android.cc:449: default:
On 2016/08/15 20:28:18, Reilly Grant wrote:
> Use an enum class and you won't need a default case.

Done.

[mcasas, 2016-08-15 21:13:48]

Patchset #2 (id:100001) has been deleted

[mcasas, 2016-08-15 21:50:27]

Patchset #2 (id:120001) has been deleted

[Tom Sepez, 2016-08-15 22:27:55]

LGTM otherwise.

https://codereview.chromium.org/2239583002/diff/140001/media/mojo/interfaces/...
File media/mojo/interfaces/image_capture.mojom (right):

https://codereview.chromium.org/2239583002/diff/140001/media/mojo/interfaces/...
media/mojo/interfaces/image_capture.mojom:40: FocusMode focus_mode;
Would Mojom's optional member feature be more appropriate here in place of the
two fields?  eg.

FocusMode? focus_mode;

Or does that have the same issue as the int32's?

[mcasas, 2016-08-15 22:58:54]

https://codereview.chromium.org/2239583002/diff/140001/media/mojo/interfaces/...
File media/mojo/interfaces/image_capture.mojom (right):

https://codereview.chromium.org/2239583002/diff/140001/media/mojo/interfaces/...
media/mojo/interfaces/image_capture.mojom:40: FocusMode focus_mode;
On 2016/08/15 22:27:55, Tom Sepez wrote:
> Would Mojom's optional member feature be more appropriate here in place of the
> two fields?  eg.
> 
> FocusMode? focus_mode;
> 
> Or does that have the same issue as the int32's?

Enum suffers from the same problem as
integer types, can't be made optional :(

AttributeError: 'Enum' object has no attribute 'MakeNullableKind'

[mcasas, 2016-08-15 22:59:06]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 22:59:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 01:33:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 01:33:21]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mcasas, 2016-08-16 01:36:39]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-08-16 01:36:40]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org,
reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2239583002/#ps140001
(title: "reillyg@ comments")

[commit-bot: I haz the power, 2016-08-16 01:36:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 03:22:10]

Description was changed from

==========
ImageCapture: support enhanced FocusMode getting/setting

This CL provides support for FocusMode getting/setting
for the ImageCapture API. In particular:

- FocusMode used to be boolean-like (manual/auto), but 
is changed to an enum throughout: "manual", "single-shot"
and "continuous", which better reflects the hardware modes.

- WebKit parts and LayoutTest updated.

- support for setting Focus is added, which forces to
 beef up the java setPhotoOptions() method. This is turn
 makes possible to bring the options |width| and |height|
 into it, and out of takePhoto(). (and that allows for them
 being removed from VCDAndroid class).

- setting FocusMode to single-shot must trigger a focus
sweep, and usually is done in AUTO mode.

BUG=518807
TEST=extensively in a N7.2, N6, N5x with
https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

to

==========
ImageCapture: support enhanced FocusMode getting/setting

This CL provides support for FocusMode getting/setting
for the ImageCapture API. In particular:

- FocusMode used to be boolean-like (manual/auto), but 
is changed to an enum throughout: "manual", "single-shot"
and "continuous", which better reflects the hardware modes.

- WebKit parts and LayoutTest updated.

- support for setting Focus is added, which forces to
 beef up the java setPhotoOptions() method. This is turn
 makes possible to bring the options |width| and |height|
 into it, and out of takePhoto(). (and that allows for them
 being removed from VCDAndroid class).

- setting FocusMode to single-shot must trigger a focus
sweep, and usually is done in AUTO mode.

BUG=518807
TEST=extensively in a N7.2, N6, N5x with
https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

[commit-bot: I haz the power, 2016-08-16 03:22:12]

Committed patchset #2 (id:140001)

[commit-bot: I haz the power, 2016-08-16 03:25:42]

Description was changed from

==========
ImageCapture: support enhanced FocusMode getting/setting

This CL provides support for FocusMode getting/setting
for the ImageCapture API. In particular:

- FocusMode used to be boolean-like (manual/auto), but 
is changed to an enum throughout: "manual", "single-shot"
and "continuous", which better reflects the hardware modes.

- WebKit parts and LayoutTest updated.

- support for setting Focus is added, which forces to
 beef up the java setPhotoOptions() method. This is turn
 makes possible to bring the options |width| and |height|
 into it, and out of takePhoto(). (and that allows for them
 being removed from VCDAndroid class).

- setting FocusMode to single-shot must trigger a focus
sweep, and usually is done in AUTO mode.

BUG=518807
TEST=extensively in a N7.2, N6, N5x with
https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

to

==========
ImageCapture: support enhanced FocusMode getting/setting

This CL provides support for FocusMode getting/setting
for the ImageCapture API. In particular:

- FocusMode used to be boolean-like (manual/auto), but
is changed to an enum throughout: "manual", "single-shot"
and "continuous", which better reflects the hardware modes.

- WebKit parts and LayoutTest updated.

- support for setting Focus is added, which forces to
 beef up the java setPhotoOptions() method. This is turn
 makes possible to bring the options |width| and |height|
 into it, and out of takePhoto(). (and that allows for them
 being removed from VCDAndroid class).

- setting FocusMode to single-shot must trigger a focus
sweep, and usually is done in AUTO mode.

BUG=518807
TEST=extensively in a N7.2, N6, N5x with
https://rawgit.com/Miguelao/demos/master/imagecapture.html

Committed: https://crrev.com/900fd602c52a2bd986c7230a2fdfacba3294db7c
Cr-Commit-Position: refs/heads/master@{#412156}
==========

[commit-bot: I haz the power, 2016-08-16 03:25:43]

Patchset 2 (id:??) landed as
https://crrev.com/900fd602c52a2bd986c7230a2fdfacba3294db7c
Cr-Commit-Position: refs/heads/master@{#412156}

[hta - Chromium, 2016-08-16 11:06:35]

On 2016/08/16 03:25:43, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/900fd602c52a2bd986c7230a2fdfacba3294db7c
> Cr-Commit-Position: refs/heads/master@{#412156}

(post-commit comment)

what's the PR number for the spec update?
Please indicate that in a comment when you go beyond what's currently published.

[mcasas, 2016-08-16 15:53:19]

On 2016/08/16 11:06:35, hta - Chromium wrote:
> On 2016/08/16 03:25:43, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/900fd602c52a2bd986c7230a2fdfacba3294db7c
> > Cr-Commit-Position: refs/heads/master@{#412156}
> 
> (post-commit comment)
> 
> what's the PR number for the spec update?
> Please indicate that in a comment when you go beyond what's currently
published.

It's https://github.com/w3c/mediacapture-image/pull/42, I thought it
straightforward enough to be merged in before this patch would land.