media/mojo/interfaces/image_capture.mojom - Issue 2239583002: ImageCapture: support enhanced FocusMode getting/setting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/interfaces/image_capture.mojom

Issue 2239583002: ImageCapture: support enhanced FocusMode getting/setting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reillyg@ comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/capture/video/android/video_capture_device_android.cc ('k') | third_party/WebKit/LayoutTests/imagecapture/setoptions.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/mojo/interfaces/image_capture.mojom

diff --git a/media/mojo/interfaces/image_capture.mojom b/media/mojo/interfaces/image_capture.mojom

index 7c7fed8260a49eaf36fe73b74595b2179198da6d..c5f0bd36a5861a8bfdca70cd5c7c3430954f001f 100644

--- a/media/mojo/interfaces/image_capture.mojom

+++ b/media/mojo/interfaces/image_capture.mojom

@@ -14,7 +14,7 @@ struct Range {

};

// https://w3c.github.io/mediacapture-image/#idl-def-FocusMode

-enum FocusMode { UNAVAILABLE, AUTO, MANUAL };

+enum FocusMode { UNAVAILABLE, MANUAL, SINGLE_SHOT, CONTINUOUS };

// Equivalent to idl PhotoCapabilities,

// https://w3c.github.io/mediacapture-image/#photocapabilities

@@ -36,6 +36,8 @@ struct PhotoSettings {

uint32 width;

bool has_height;

uint32 height;

+ bool has_focus_mode;

+ FocusMode focus_mode;

Tom Sepez 2016/08/15 22:27:55 Would Mojom's optional member feature be more appr

mcasas 2016/08/15 22:58:54 Enum suffers from the same problem as integer type

};

// This is a mojo move-only equivalent of a Blob, i.e. MIME type and Data.