Fix crash in viewer on certain android devices

Fix crash in viewer on certain android devices

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239493002

Committed: https://skia.googlesource.com/skia/+/f5fe4b556735150d5c6383996b8c0f9816a8db51

[egdaniel, 2016-08-10 20:44:48]

Description was changed from

==========
Fix crash in viewer on certain android devices

BUG=skia:
==========

to

==========
Fix crash in viewer on certain android devices

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239493002
==========

[egdaniel, 2016-08-10 21:00:12]

egdaniel@google.com changed reviewers:
+ jvanverth@google.com

[egdaniel, 2016-08-10 21:00:13]

So on certain devices, as the viewer app is open, the create surface is getting
different VkInstances and when you get the function pntr to the
vkCreateAndroidSurfaceKHR function it will return different function ptrs. Thus
in the old case we'd try reusing the old function ptr which seems to no longer
valid. Forcing us to always query the ptr each time fixes the crash.

I don't know enough about the inner workings of this code, but does it make
sense that we are creating different VkInstance's in the first place? I suppose
if we don't have different instances it is technically valid for the
driver/loader to return different ptrs here (even though that still seems a
little strange).

[jvanverth1, 2016-08-11 14:05:13]

lgtm + suggestion

https://codereview.chromium.org/2239493002/diff/1/tools/viewer/sk_app/android...
File tools/viewer/sk_app/android/VulkanWindowContext_android.cpp (right):

https://codereview.chromium.org/2239493002/diff/1/tools/viewer/sk_app/android...
tools/viewer/sk_app/android/VulkanWindowContext_android.cpp:18:
PFN_vkCreateAndroidSurfaceKHR createAndroidSurfaceKHR = nullptr;
Merge these two lines together?

[egdaniel, 2016-08-11 14:18:00]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-08-11 14:18:00]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/2239493002/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2016-08-11 14:18:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 14:18:05]

This CL has an open dependency (Issue 2238563002 Patch 40001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[egdaniel, 2016-08-11 14:56:47]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-08-11 14:56:47]

The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/2239493002/#ps40001
(title: "fix branch")

[commit-bot: I haz the power, 2016-08-11 14:56:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 15:15:15]

Description was changed from

==========
Fix crash in viewer on certain android devices

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239493002
==========

to

==========
Fix crash in viewer on certain android devices

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239493002

Committed:
https://skia.googlesource.com/skia/+/f5fe4b556735150d5c6383996b8c0f9816a8db51
==========

[commit-bot: I haz the power, 2016-08-11 15:15:15]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f5fe4b556735150d5c6383996b8c0f9816a8db51