Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2242553002: Allow vulkan to upload data to testing textures with optimal layouts (Closed)

Created:
4 years, 4 months ago by egdaniel
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@yuv
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Allow vulkan to upload data to testing textures with optimal layouts BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2242553002 Committed: https://skia.googlesource.com/skia/+/3602d4f16a01da860d16eb36fb52eb62487495cc

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -25 lines) Patch
M gm/imagefromyuvtextures.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 4 chunks +193 lines, -23 lines 0 comments Download
M src/gpu/vk/GrVkImage.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
egdaniel
enjoy :) https://codereview.chromium.org/2242553002/diff/1/gm/imagefromyuvtextures.cpp File gm/imagefromyuvtextures.cpp (right): https://codereview.chromium.org/2242553002/diff/1/gm/imagefromyuvtextures.cpp#newcode34 gm/imagefromyuvtextures.cpp:34: return SkISize::Make(50, 175); we we're cutting off ...
4 years, 4 months ago (2016-08-11 19:40:09 UTC) #3
jvanverth1
Ugly, but functional. lgtm https://codereview.chromium.org/2242553002/diff/1/src/gpu/vk/GrVkGpu.cpp File src/gpu/vk/GrVkGpu.cpp (right): https://codereview.chromium.org/2242553002/diff/1/src/gpu/vk/GrVkGpu.cpp#newcode1190 src/gpu/vk/GrVkGpu.cpp:1190: // Create Fence for queue ...
4 years, 4 months ago (2016-08-11 20:42:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242553002/1
4 years, 4 months ago (2016-08-11 20:48:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Release-Vulkan-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Release-Vulkan-Trybot/builds/713)
4 years, 4 months ago (2016-08-11 21:20:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242553002/20001
4 years, 4 months ago (2016-08-12 18:57:53 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/3602d4f16a01da860d16eb36fb52eb62487495cc
4 years, 4 months ago (2016-08-12 18:58:56 UTC) #17
robertphillips
4 years, 4 months ago (2016-08-15 13:02:22 UTC) #19
Message was sent while issue was closed.
This seems to have broken the X1 and Windows10 Vulkan bots with:

FAILURE: ../../../tests/SurfaceTest.cpp:854	origColorPM == pixels[x + y * kW]

Powered by Google App Engine
This is Rietveld 408576698