Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2232943002: Revert of [Android] Make it possible to show Infobar in native pages (Closed)

Created:
4 years, 4 months ago by huangs
Modified:
4 years, 4 months ago
Reviewers:
Ted C, Ian Wen, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Make it possible to show Infobar in native pages (patchset #4 id:60001 of https://codereview.chromium.org/2224853003/ ) Reason for revert: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35661 This CL may have caused new test failures in Android Tests: org.chromium.chrome.browser.TabsTest#testCloseFiveIncognitoTabLandscape org.chromium.chrome.browser.TabsTest#testCloseFiveIncognitoTabPortrait Original issue's description: > [Android] Make it possible to show Infobar in native pages > > This CL enables Chrome to show infobar in native pages, especially in > the NTP. From now on, Tab.getView() will always return the wrapper that > holds both infobar container and the tab's content, which could be a > native page or a content view, rendered by blink/compositor. > > BUG=508307 > TBR=tedchoc@chromium.org > > Committed: https://crrev.com/6943a9a92a909bb927080ef6c7658ddbce3a3ae7 > Cr-Commit-Position: refs/heads/master@{#410996} TBR=dfalcantara@chromium.org,tedchoc@chromium.org,ianwen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=508307 Committed: https://crrev.com/e7d6672558a2e7ec736a07d25465a74bfbb8f24e Cr-Commit-Position: refs/heads/master@{#411045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -58 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabContentViewParent.java View 2 chunks +2 lines, -45 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/UiUtils.java View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
huangs
Created Revert of [Android] Make it possible to show Infobar in native pages
4 years, 4 months ago (2016-08-10 15:25:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232943002/1
4 years, 4 months ago (2016-08-10 15:25:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 15:26:26 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 15:29:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7d6672558a2e7ec736a07d25465a74bfbb8f24e
Cr-Commit-Position: refs/heads/master@{#411045}

Powered by Google App Engine
This is Rietveld 408576698