Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: platform_tools/android/bin/android_make

Issue 223943002: android_make now exactly the same as android_ninja (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: move set -e Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/bin/android_make
diff --git a/platform_tools/android/bin/android_make b/platform_tools/android/bin/android_make
index a5f5268931010c134cbf19a6fc15888ef2bb41ce..a465a43b0aee86052e1e52acc1bef5c4625a3a35 100755
--- a/platform_tools/android/bin/android_make
+++ b/platform_tools/android/bin/android_make
@@ -1,8 +1,5 @@
#!/bin/bash
-# Fail-fast if anything in the script fails.
-set -e
-
# Remove any existing .android_config file before running android_setup. If we
# did not remove this now then we would build for whatever device type was
# listed in the .android_config instead of the default device type.
@@ -11,14 +8,16 @@ rm -f .android_config
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source $SCRIPT_DIR/android_setup.sh
-if [ $(basename $0) = "android_make" ]; then
- GYP_GENERATORS=make-android make ${APP_ARGS[@]}
-else
- GYP_GENERATORS=ninja-android ./gyp_skia
- OUT=$SKIA_OUT/${BUILDTYPE-Debug} # Defaults to Debug if BUILDTYPE isn't set.
- ninja -C $OUT ${APP_ARGS[@]}
- ln -sf lib $OUT/lib.target # android_run_skia looks in lib.target; ninja writes to lib.
-fi
+# Fail-fast if anything in the script fails.
+# Don't do this until "source android_setup.sh" is done; see
+# https://codereview.chromium.org/223943002 for discussion.
+set -e
+
+GYP_GENERATORS=ninja-android ./gyp_skia
+OUT=$SKIA_OUT/${BUILDTYPE-Debug} # Defaults to Debug if BUILDTYPE isn't set.
+ninja -C $OUT ${APP_ARGS[@]}
+ln -sf lib $OUT/lib.target # android_run_skia looks in lib.target; ninja writes to lib.
+ # TODO(mtklein): change android_run_skia
# Write the device id into the .android_config file. This tells
# android_run_skia the last build we completed.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698