Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: platform_tools/android/bin/android_make

Issue 223943002: android_make now exactly the same as android_ninja (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: move set -e Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/bin/bash 1 #!/bin/bash
2 2
3 # Fail-fast if anything in the script fails.
4 set -e
5
6 # Remove any existing .android_config file before running android_setup. If we 3 # Remove any existing .android_config file before running android_setup. If we
7 # did not remove this now then we would build for whatever device type was 4 # did not remove this now then we would build for whatever device type was
8 # listed in the .android_config instead of the default device type. 5 # listed in the .android_config instead of the default device type.
9 rm -f .android_config 6 rm -f .android_config
10 7
11 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" 8 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
12 source $SCRIPT_DIR/android_setup.sh 9 source $SCRIPT_DIR/android_setup.sh
13 10
14 if [ $(basename $0) = "android_make" ]; then 11 # Fail-fast if anything in the script fails.
15 GYP_GENERATORS=make-android make ${APP_ARGS[@]} 12 # Don't do this until "source android_setup.sh" is done; see
16 else 13 # https://codereview.chromium.org/223943002 for discussion.
17 GYP_GENERATORS=ninja-android ./gyp_skia 14 set -e
18 OUT=$SKIA_OUT/${BUILDTYPE-Debug} # Defaults to Debug if BUILDTYPE isn't se t. 15
19 ninja -C $OUT ${APP_ARGS[@]} 16 GYP_GENERATORS=ninja-android ./gyp_skia
20 ln -sf lib $OUT/lib.target # android_run_skia looks in lib.target; n inja writes to lib. 17 OUT=$SKIA_OUT/${BUILDTYPE-Debug} # Defaults to Debug if BUILDTYPE isn't set.
21 fi 18 ninja -C $OUT ${APP_ARGS[@]}
19 ln -sf lib $OUT/lib.target # android_run_skia looks in lib.target; ninja writes to lib.
20 # TODO(mtklein): change android_run_skia
22 21
23 # Write the device id into the .android_config file. This tells 22 # Write the device id into the .android_config file. This tells
24 # android_run_skia the last build we completed. 23 # android_run_skia the last build we completed.
25 echo $DEVICE_ID > .android_config 24 echo $DEVICE_ID > .android_config
26 25
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698