Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2239353002: Ignored title in shadow should cause StyleSheet.title = null. (Closed)

Created:
4 years, 4 months ago by rune
Modified:
4 years, 4 months ago
Reviewers:
hayato
CC:
chromium-reviews, Yoav Weiss, blink-reviews-html_chromium.org, gavinp+prerender_chromium.org, blink-reviews-style_chromium.org, sof, eae+blinkwatch, fs, blink-reviews-dom_chromium.org, dglazkov+blink, krit, f(malita), blink-reviews, gyuyoung2, Stephen Chennney, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignored title in shadow should cause StyleSheet.title = null. https://github.com/w3c/webcomponents/issues/535#issuecomment-239437022 R=hayato@chromium.org Committed: https://crrev.com/6ebe7f1c3b837249a0dcd768e55197745e106fc8 Cr-Commit-Position: refs/heads/master@{#411942}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/shadow/alternate-stylesheets.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/alternate-stylesheets-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/link-title.html View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLStyleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStyleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
rune
4 years, 4 months ago (2016-08-12 16:32:01 UTC) #5
hayato
Ah. I think that stylesheet.title should return the title attribute value as is, though its ...
4 years, 4 months ago (2016-08-15 04:23:12 UTC) #6
hayato
I see. That's from Anne's comment: https://github.com/w3c/webcomponents/issues/535#issuecomment-239437022. Let me think about it.
4 years, 4 months ago (2016-08-15 04:28:09 UTC) #7
hayato
Stylesheet.prototype.title looks read only attribute. Thus, it looks okay. LGTM.
4 years, 4 months ago (2016-08-15 04:30:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239353002/1
4 years, 4 months ago (2016-08-15 05:03:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 06:30:02 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 06:31:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ebe7f1c3b837249a0dcd768e55197745e106fc8
Cr-Commit-Position: refs/heads/master@{#411942}

Powered by Google App Engine
This is Rietveld 408576698