third_party/WebKit/Source/core/svg/SVGStyleElement.cpp - Issue 2239353002: Ignored title in shadow should cause StyleSheet.title = null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGStyleElement.cpp

Issue 2239353002: Ignored title in shadow should cause StyleSheet.title = null. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/svg/SVGStyleElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGStyleElement.cpp b/third_party/WebKit/Source/core/svg/SVGStyleElement.cpp

index e7a2086a1bc61a16875f51fbd2852b24bd48f84f..8a9ad0bd8e984b609a37ae5185b864c4f3900c5b 100644

--- a/third_party/WebKit/Source/core/svg/SVGStyleElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGStyleElement.cpp

@@ -100,7 +100,7 @@ void SVGStyleElement::setTitle(const AtomicString& title)

void SVGStyleElement::parseAttribute(const QualifiedName& name, const AtomicString& oldValue, const AtomicString& value)

{

if (name == SVGNames::titleAttr) {

- if (m_sheet)

+ if (m_sheet && isInDocumentTree())

m_sheet->setTitle(value);

return;

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLStyleElement.cpp ('k') | no next file » | no next file with comments »