Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2239323002: Revert of "[heap] Switch to 500k pages" (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of "[heap] Switch to 500k pages" (patchset #11 id:220001 of https://codereview.chromium.org/2232653003/ ) Reason for revert: Breaks benchmark with --turbo on avx2 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20avx2/builds/9895 Original issue's description: > Reland of "[heap] Switch to 500k pages" > > Decrease regular heap object size to 400k. In a follow up, we can now get rid of > the new space border page while keeping the 1M minimum new space size. > > BUG=chromium:636331 > > This reverts commit 555c961990088d545e2b475da3872bd63fa27569. > > Committed: https://crrev.com/20e2ea80e169e85c5b8231adc02901fb6c989609 > Cr-Commit-Position: refs/heads/master@{#38608} TBR=hpayer@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:636331 Committed: https://crrev.com/1617043c1093870d67eede7828467cc3b77ba9fb Cr-Commit-Position: refs/heads/master@{#38613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -301 lines) Patch
M src/base/build_config.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/heap/spaces.h View 6 chunks +2 lines, -14 lines 0 comments Download
M src/heap/spaces.cc View 5 chunks +11 lines, -72 lines 0 comments Download
M src/isolate.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M src/objects.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/snapshot/snapshot.h View 2 chunks +12 lines, -4 lines 0 comments Download
M src/snapshot/snapshot-common.cc View 4 chunks +67 lines, -3 lines 0 comments Download
M test/cctest/heap/heap-utils.h View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 4 chunks +7 lines, -20 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 4 chunks +11 lines, -120 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Lippautz
Created Revert of "[heap] Switch to 500k pages"
4 years, 4 months ago (2016-08-12 11:42:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239323002/1
4 years, 4 months ago (2016-08-12 11:42:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 11:42:29 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1617043c1093870d67eede7828467cc3b77ba9fb Cr-Commit-Position: refs/heads/master@{#38613}
4 years, 4 months ago (2016-08-12 11:42:45 UTC) #7
Michael Lippautz
4 years, 3 months ago (2016-08-25 14:53:39 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2276973004/ by mlippautz@chromium.org.

The reason for reverting is: The underlying issue crbug.com/637279 has been
fixed. Let's go again!.

Powered by Google App Engine
This is Rietveld 408576698