Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 2239273002: Don't use SSLStatus from FrameHostMsg_DidCommitProvisionalLoad and instead cache it on the browser … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl_unittest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc
index 45a1614b674a6af7ced90e278a722e5c563e4116..d7019d7ee2aea7a4807af6457f2856bb3dfcd1f5 100644
--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc
@@ -5324,46 +5324,4 @@ TEST_F(NavigationControllerTest, StaleNavigationsResurrected) {
EXPECT_EQ(url_b, controller.GetEntryAtIndex(2)->GetURL());
}
-// Test that if a renderer provides bogus security info (that fails to
-// deserialize properly) when reporting a navigation, the renderer gets
-// killed.
-TEST_F(NavigationControllerTest, RendererNavigateBogusSecurityInfo) {
- GURL url("http://foo.test");
- controller().LoadURL(url, Referrer(), ui::PAGE_TRANSITION_TYPED,
- std::string());
- FrameHostMsg_DidCommitProvisionalLoad_Params params;
- params.page_id = 0;
- params.nav_entry_id = 0;
- params.did_create_new_entry = true;
- params.url = url;
- params.transition = ui::PAGE_TRANSITION_LINK;
- params.should_update_history = true;
- params.gesture = NavigationGestureUser;
- params.method = "GET";
- params.page_state = PageState::CreateFromURL(url);
- params.was_within_same_page = false;
- params.security_info = "bogus security info!";
-
- LoadCommittedDetailsObserver observer(contents());
- EXPECT_EQ(0, main_test_rfh()->GetProcess()->bad_msg_count());
- main_test_rfh()->PrepareForCommit();
- main_test_rfh()->SendNavigateWithParams(&params);
-
- SSLStatus default_ssl_status;
- EXPECT_EQ(default_ssl_status.security_style,
- observer.details().ssl_status.security_style);
- EXPECT_EQ(default_ssl_status.cert_id, observer.details().ssl_status.cert_id);
- EXPECT_EQ(default_ssl_status.cert_status,
- observer.details().ssl_status.cert_status);
- EXPECT_EQ(default_ssl_status.security_bits,
- observer.details().ssl_status.security_bits);
- EXPECT_EQ(default_ssl_status.connection_status,
- observer.details().ssl_status.connection_status);
- EXPECT_EQ(default_ssl_status.content_status,
- observer.details().ssl_status.content_status);
- EXPECT_EQ(default_ssl_status.sct_statuses,
- observer.details().ssl_status.sct_statuses);
- EXPECT_EQ(1, main_test_rfh()->GetProcess()->bad_msg_count());
-}
-
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698