Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 2239273002: Don't use SSLStatus from FrameHostMsg_DidCommitProvisionalLoad and instead cache it on the browser … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index dd60d9ac980eb697e9014885d2a03abc04eae063..84c09d5d53feddf33a40eac12684cc00fb5164aa 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -923,15 +923,6 @@ bool NavigationControllerImpl::RendererDidNavigate(
details->is_main_frame = !rfh->GetParent();
details->http_status_code = params.http_status_code;
- // Deserialize the security info and kill the renderer if
- // deserialization fails. The navigation will continue with default
- // SSLStatus values.
- if (!DeserializeSecurityInfo(params.security_info, &details->ssl_status)) {
- bad_message::ReceivedBadMessage(
- rfh->GetProcess(),
- bad_message::WC_RENDERER_DID_NAVIGATE_BAD_SECURITY_INFO);
- }
-
NotifyNavigationEntryCommitted(details);
// Update the nav_entry_id for each RenderFrameHost in the tree, so that each
@@ -1107,6 +1098,7 @@ void NavigationControllerImpl::RendererDidNavigateToNewPage(
new_entry = pending_entry_->Clone();
update_virtual_url = new_entry->update_virtual_url_with_url();
+ new_entry->GetSSL() = handle->ssl_status();
}
// For non-in-page commits with no matching pending entry, create a new entry.
@@ -1127,6 +1119,7 @@ void NavigationControllerImpl::RendererDidNavigateToNewPage(
// to show chrome://bookmarks/#1 when the bookmarks webui extension changes
// the URL.
update_virtual_url = needs_update;
+ new_entry->GetSSL() = handle->ssl_status();
}
// Don't use the page type from the pending entry. Some interstitial page

Powered by Google App Engine
This is Rietveld 408576698