Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2239273002: Don't use SSLStatus from FrameHostMsg_DidCommitProvisionalLoad and instead cache it on the browser … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge and comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 4baadd4d16beb6e1c3ffb254b0f43c5c1b6fa11c..9babb0980738dc6ced8b34c1bc883279bda227ef 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -36,6 +36,7 @@
#include "content/common/navigation_params.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/common/javascript_message_type.h"
+#include "content/public/common/ssl_status.h"
#include "media/mojo/interfaces/service_factory.mojom.h"
#include "net/http/http_response_headers.h"
#include "services/shell/public/cpp/interface_factory.h"
@@ -603,6 +604,10 @@ class CONTENT_EXPORT RenderFrameHostImpl
return last_navigation_lofi_state_;
}
+ void SetSSLStatusForPendingNavigate(const GURL& url,
+ const SSLStatus& ssl_status);
+ bool GetSSLStatusForPendingNavigate(const GURL& url, SSLStatus* ssl_status);
+
protected:
friend class RenderFrameHostFactory;
@@ -1056,6 +1061,9 @@ class CONTENT_EXPORT RenderFrameHostImpl
std::vector<std::unique_ptr<shell::InterfaceRegistry>> media_registries_;
+ GURL pending_navigate_ssl_status_url_;
+ SSLStatus pending_navigate_ssl_status_;
nasko 2016/08/15 22:18:22 If the SSLStatus is used only for the main frame,
jam 2016/08/15 22:57:37 Are you thinking of storing this temporary object
+
// NOTE: This must be the last member.
base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698