Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2239273002: Don't use SSLStatus from FrameHostMsg_DidCommitProvisionalLoad and instead cache it on the browser … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge and comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 317829c0f9c1bafa77d962e25ef1f2102389e663..8391e0c31f8cb80174614c135cac1a86630b9701 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -2637,6 +2637,24 @@ void RenderFrameHostImpl::SuppressFurtherDialogs() {
Send(new FrameMsg_SuppressFurtherDialogs(GetRoutingID()));
}
+void RenderFrameHostImpl::SetSSLStatusForPendingNavigate(
+ const GURL& url, const SSLStatus& ssl_status) {
+ pending_navigate_ssl_status_url_ = url;
+ pending_navigate_ssl_status_ = ssl_status;
+}
+
+bool RenderFrameHostImpl::GetSSLStatusForPendingNavigate(
+ const GURL& url, SSLStatus* status) {
+ bool rv = false;
+ if (url == pending_navigate_ssl_status_url_) {
+ *status = pending_navigate_ssl_status_;
+ rv = true;
+ }
+ pending_navigate_ssl_status_url_ = GURL();
nasko 2016/08/15 22:18:22 Why would we not match the URL? I'd rather not ret
jam 2016/08/15 22:57:37 it's the same reason for resource_loader.cc's SetS
+ pending_navigate_ssl_status_ = SSLStatus();
+ return rv;
+}
+
bool RenderFrameHostImpl::IsSameSiteInstance(
RenderFrameHostImpl* other_render_frame_host) {
// As a sanity check, make sure the frame belongs to the same BrowserContext.

Powered by Google App Engine
This is Rietveld 408576698