Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2239223003: Remove usage of wasThrown from inspector_runtime.py (Closed)

Created:
4 years, 4 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
Zhen Wang
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Remove usage of wasThrown from inspector_runtime.py wasThrown was hidden in remote debugging protocol, it will be removed soon. exceptionDetails can be used instead of was wasThrown. R=zhenw@chromium.org Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a6c1fefb2149fa5fb611a13e10f28a8569960d99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
kozy
Zhen, please take a look!
4 years, 4 months ago (2016-08-12 17:52:41 UTC) #4
Zhen Wang
lgtm
4 years, 4 months ago (2016-08-12 18:18:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239223003/1
4 years, 4 months ago (2016-08-12 18:19:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/3708)
4 years, 4 months ago (2016-08-12 18:55:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239223003/1
4 years, 4 months ago (2016-08-12 18:56:58 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 19:16:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698