Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py

Issue 2239223003: Remove usage of wasThrown from inspector_runtime.py (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py
diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py
index b3c250e0e89fa04ae860c7e5f2ef6921a8546ae4..93dafd3bb4abf64199b42c75a881958ef3a82be4 100644
--- a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py
+++ b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py
@@ -46,10 +46,11 @@ class InspectorRuntime(object):
if 'error' in res:
raise exceptions.EvaluateException(res['error']['message'])
- if 'wasThrown' in res['result'] and res['result']['wasThrown']:
+ if 'exceptionDetails' in res['result']:
# TODO(nduca): propagate stacks from javascript up to the python
# exception.
- raise exceptions.EvaluateException(res['result']['result']['description'])
+ text = res['result']['exceptionDetails']['text']
+ raise exceptions.EvaluateException(text)
if res['result']['result']['type'] == 'undefined':
return None
return res['result']['result']['value']
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698