Improvements to warnings on message extraction.

pkg/intl/test/message_extraction/sample_with_messages.dart

Index: pkg/intl/test/message_extraction/sample_with_messages.dart
diff --git a/pkg/intl/test/message_extraction/sample_with_messages.dart b/pkg/intl/test/message_extraction/sample_with_messages.dart
index 9bad4b9ecab27139af6285f62dc858b6a9be5c7c..cfebc804be808baef3cdde706d6892d5c8387787 100644
--- a/pkg/intl/test/message_extraction/sample_with_messages.dart
+++ b/pkg/intl/test/message_extraction/sample_with_messages.dart
@@ -38,7 +38,7 @@ types(int a, String b, List c) => Intl.message("$a, $b, $c", name: 'types',
 
 // This string will be printed with a French locale, so it will always show
 // up in the French version, regardless of the current locale.
-alwaysAccented() =>
+alwaysTranslated() =>
     Intl.message("This string is always translated", locale: 'fr',
         name: 'alwaysTranslated');
 
@@ -101,12 +101,16 @@ printStuff(Intl locale) {
 
   // A function that is unnamed and assigned to a variable. It's also nested
   // within another function definition.
-  var messageVariable = (a, b, c) => Intl.message(
+  // TODO(alanknight): This is assigned a regular name now because it conflicts
+  // with validating that the name argument matches the function name. It's
+  // not clear if anonymous functions are an important use case to support.

[Emily Fortuna, 2013/08/06 19:31:30]

I thought we explicitly said in the design doc that we weren't going to allow
anonymous functions. Period. That was just one limitation that our users would
have to deal with. 

[Alan Knight, 2013/08/06 20:00:26]

Excellent, I'd forgotten. Removed the TODO.

+  message3(a, b, c) => Intl.message(
       "Characters that need escaping, e.g slashes \\ dollars \${ (curly braces "
       "are ok) and xml reserved characters <& and quotes \" "
       "parameters $a, $b, and $c",
       name: 'message3',
       args: [a, b, c]);
+  var messageVariable = message3;
 
   print("-------------------------------------------");
   print("Printing messages for ${locale.locale}");
@@ -117,7 +121,7 @@ printStuff(Intl locale) {
     print(multiLine());
     print(types(1, "b", ["c", "d"]));
     print(leadingQuotes());
-    print(alwaysAccented());
+    print(alwaysTranslated());
     print(trickyInterpolation("this"));
     var thing = new YouveGotMessages();
     print(thing.method());