chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h - Issue 2239133002: [Offline pages] Downloads UI: Adding bridge for issuing notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h

Issue 2239133002: [Offline pages] Downloads UI: Adding bridge for issuing notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@download-notifications

Patch Set: Addressing CR feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java ('k') | chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h

diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h

index 41f94ec8f1ce6ff056f75fc18b2773fbdcbfca40..46302b3a8a2d22d48e2c2faa8d7e10d0c22c8ea6 100644

--- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h

+++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h

@@ -70,7 +70,8 @@ class OfflinePageDownloadBridge : public DownloadUIAdapter::Observer {

void ItemDeleted(const std::string& guid) override;

private:

- void SavePageCallback(OfflinePageModel::SavePageResult result,

+ void SavePageCallback(const DownloadUIItem& item,

+ OfflinePageModel::SavePageResult result,

int64_t offline_id);

JavaObjectWeakGlobalRef weak_java_ref_;