Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4365)

Unified Diff: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

Issue 2239133002: [Offline pages] Downloads UI: Adding bridge for issuing notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@download-notifications
Patch Set: Addressing CR feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
index a99688924993a3784e749a2552230bdfe8954bf3..b30d73dd6e53435bf97beeb2224717f5ead075d0 100644
--- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
+++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
@@ -9,6 +9,7 @@
#include "base/android/jni_string.h"
#include "base/guid.h"
#include "base/memory/ptr_util.h"
+#include "chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.h"
#include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"
#include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
#include "chrome/browser/android/tab_android.h"
@@ -147,10 +148,17 @@ void OfflinePageDownloadBridge::StartDownload(
client_id.name_space = offline_pages::kDownloadNamespace;
client_id.id = base::GenerateGUID();
+ DownloadUIItem item;
+ item.guid = client_id.id;
+ item.url = url;
+
+ OfflinePageNotificationBridge bridge;
+ bridge.NotifyDownloadProgress(item);
+
offline_page_model->SavePage(
url, client_id, 0ul, std::move(archiver),
base::Bind(&OfflinePageDownloadBridge::SavePageCallback,
- weak_ptr_factory_.GetWeakPtr()));
+ weak_ptr_factory_.GetWeakPtr(), item));
}
void OfflinePageDownloadBridge::ItemsLoaded() {
@@ -189,8 +197,14 @@ void OfflinePageDownloadBridge::ItemUpdated(const DownloadUIItem& item) {
}
void OfflinePageDownloadBridge::SavePageCallback(
- OfflinePageModel::SavePageResult result, int64_t offline_id) {
- // TODO(dimich): Consider adding UMA here.
+ const DownloadUIItem& item,
+ OfflinePageModel::SavePageResult result,
+ int64_t offline_id) {
+ OfflinePageNotificationBridge notification_bridge;
+ if (result == SavePageResult::SUCCESS)
+ notification_bridge.NotifyDownloadSuccessful(item);
+ else
+ notification_bridge.NotifyDownloadFailed(item);
}
static jlong Init(JNIEnv* env,

Powered by Google App Engine
This is Rietveld 408576698