chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java - Issue 2239133002: [Offline pages] Downloads UI: Adding bridge for issuing notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

Issue 2239133002: [Offline pages] Downloads UI: Adding bridge for issuing notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@download-notifications

Patch Set: Addressing CR feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java b/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

index 5d31a2f3ea8b09f85a39e9973e5c0b237f940ddb..4eb0184bb81e63e749d665832c08d8dd790b0a12 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

@@ -264,11 +264,11 @@ public class SystemDownloadNotifier implements DownloadNotifier {

} else {

switch (notificationInfo.type) {

case DOWNLOAD_NOTIFICATION_TYPE_PROGRESS:

- mBoundService.notifyDownloadProgress(

- info.getDownloadGuid(), info.getFileName(),

- info.getPercentCompleted(), info.getTimeRemainingInMillis(),

- notificationInfo.startTime, info.isOffTheRecord(),

- notificationInfo.canDownloadWhileMetered);

+ mBoundService.notifyDownloadProgress(info.getDownloadGuid(),

+ info.getFileName(), info.getPercentCompleted(),

+ info.getTimeRemainingInMillis(), notificationInfo.startTime,

+ info.isOffTheRecord(), notificationInfo.canDownloadWhileMetered,

+ info.isOfflinePage());

break;

case DOWNLOAD_NOTIFICATION_TYPE_PAUSE:

mBoundService.notifyDownloadPaused(info.getDownloadGuid(), true, false);

@@ -281,7 +281,7 @@ public class SystemDownloadNotifier implements DownloadNotifier {

case DOWNLOAD_NOTIFICATION_TYPE_SUCCESS:

final int notificationId = mBoundService.notifyDownloadSuccessful(

info.getDownloadGuid(), info.getFileName(),

- notificationInfo.systemDownloadId);

+ notificationInfo.systemDownloadId, info.isOfflinePage());

onSuccessNotificationShown(notificationInfo, notificationId);

stopServiceIfNeeded();

break;