chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java - Issue 2239133002: [Offline pages] Downloads UI: Adding bridge for issuing notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java

Issue 2239133002: [Offline pages] Downloads UI: Adding bridge for issuing notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@download-notifications

Patch Set: Addressing CR feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java

index 91584e757954bbe2d91584378d5ef46db4648446..48dabbf3d305906168c69fa4f3d4b3e46aba735a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java

@@ -29,4 +29,13 @@ public interface DownloadServiceDelegate {

* TODO(fgorski): Update the interface to not require download item.

void resumeDownload(DownloadItem item, boolean hasUserGesture);

+ /**

+ * Called to open a download item.

+ * @param downloadGuid GUID of the download.

+ */

+ void openItem(String downloadGuid);

+ /** Called to destroy the delegate, in case it needs to be destroyed. */

+ void destroyServiceDelegate();

}