components/offline_pages/background/request_coordinator.h - Issue 2239133002: [Offline pages] Downloads UI: Adding bridge for issuing notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2239133002: [Offline pages] Downloads UI: Adding bridge for issuing notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@download-notifications

Patch Set: Minimizing the patch to handle direct WC capture on download button Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc ('K') | « components/offline_pages.gypi ('k') | components/offline_pages/background/request_coordinator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_coordinator.h

diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h

index 6804c9ba7376918c128c780c8c72adf9a67de611..d0c3af317b4a75f1b151795036265ec2b106c464 100644

--- a/components/offline_pages/background/request_coordinator.h

+++ b/components/offline_pages/background/request_coordinator.h

@@ -52,6 +52,7 @@ class RequestCoordinator : public KeyedService {

// events after the return callback from |GetAllRequests|.

class Observer {

public:

+ virtual ~Observer() = default;

virtual void OnAdded(const SavePageRequest& request) = 0;

virtual void OnCompleted(const SavePageRequest& request,

SavePageStatus status) = 0;