Chromium Code Reviews| Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc |
| diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc |
| index a99688924993a3784e749a2552230bdfe8954bf3..ee5a957a62cd1140425be78830f991fd85cda34d 100644 |
| --- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc |
| +++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc |
| @@ -9,6 +9,7 @@ |
| #include "base/android/jni_string.h" |
| #include "base/guid.h" |
| #include "base/memory/ptr_util.h" |
| +#include "chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.h" |
| #include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h" |
| #include "chrome/browser/android/offline_pages/offline_page_model_factory.h" |
| #include "chrome/browser/android/tab_android.h" |
| @@ -147,10 +148,17 @@ void OfflinePageDownloadBridge::StartDownload( |
| client_id.name_space = offline_pages::kDownloadNamespace; |
| client_id.id = base::GenerateGUID(); |
| + DownloadUIItem item; |
| + item.guid = client_id.id; |
| + item.url = url; |
| + |
| + OfflinePageNotificationBridge bridge; |
| + bridge.NotifyDownloadProgress(item); |
| + |
| offline_page_model->SavePage( |
| url, client_id, 0ul, std::move(archiver), |
| base::Bind(&OfflinePageDownloadBridge::SavePageCallback, |
| - weak_ptr_factory_.GetWeakPtr())); |
| + weak_ptr_factory_.GetWeakPtr(), item)); |
| } |
| void OfflinePageDownloadBridge::ItemsLoaded() { |
| @@ -189,8 +197,15 @@ void OfflinePageDownloadBridge::ItemUpdated(const DownloadUIItem& item) { |
| } |
| void OfflinePageDownloadBridge::SavePageCallback( |
| - OfflinePageModel::SavePageResult result, int64_t offline_id) { |
| - // TODO(dimich): Consider adding UMA here. |
| + const DownloadUIItem& item, |
| + OfflinePageModel::SavePageResult result, |
| + int64_t offline_id) { |
| + OfflinePageNotificationBridge notification_bridge; |
| + if (result == SavePageResult::SUCCESS) { |
|
qinmin
2016/08/18 23:46:59
no need for {} for if-else statements that has onl
fgorski
2016/08/19 17:03:24
Done.
|
| + notification_bridge.NotifyDownloadSuccessful(item); |
| + } else { |
| + notification_bridge.NotifyDownloadFailed(item); |
| + } |
| } |
| static jlong Init(JNIEnv* env, |