[Offline pages] Downloads UI: Adding bridge for issuing notifications

chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h"
 
 #include <vector>
 
 #include "base/android/jni_string.h"
 #include "base/guid.h"
 #include "base/memory/ptr_util.h"
+#include "chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.h"
 #include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"
 #include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
 #include "chrome/browser/android/tab_android.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_android.h"
 #include "components/offline_pages/client_namespace_constants.h"
 #include "components/offline_pages/downloads/download_ui_item.h"
 #include "components/offline_pages/offline_page_model.h"
 #include "content/public/browser/web_contents.h"
 #include "jni/OfflinePageDownloadBridge_jni.h"
@@ skipping 118 matching lines @@
     return;
 
   GURL url = web_contents->GetLastCommittedURL();
   auto archiver =
       base::MakeUnique<offline_pages::OfflinePageMHTMLArchiver>(web_contents);
 
   offline_pages::ClientId client_id;
   client_id.name_space = offline_pages::kDownloadNamespace;
   client_id.id = base::GenerateGUID();
 
+  DownloadUIItem item;
+  item.guid = client_id.id;
+  item.url = url;
+
+  OfflinePageNotificationBridge bridge;
+  bridge.NotifyDownloadProgress(item);
+
   offline_page_model->SavePage(
       url, client_id, 0ul, std::move(archiver),
       base::Bind(&OfflinePageDownloadBridge::SavePageCallback,
-                 weak_ptr_factory_.GetWeakPtr()));
+                 weak_ptr_factory_.GetWeakPtr(), item));
 }
 
 void OfflinePageDownloadBridge::ItemsLoaded() {
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jobject> obj = weak_java_ref_.get(env);
   if (obj.is_null())
     return;
   Java_OfflinePageDownloadBridge_downloadItemsLoaded(env, obj);
 }
 
@@ skipping 18 matching lines @@
 void OfflinePageDownloadBridge::ItemUpdated(const DownloadUIItem& item) {
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jobject> obj = weak_java_ref_.get(env);
   if (obj.is_null())
     return;
   Java_OfflinePageDownloadBridge_downloadItemUpdated(
       env, obj, ToJavaOfflinePageDownloadItem(env, item));
 }
 
 void OfflinePageDownloadBridge::SavePageCallback(
-    OfflinePageModel::SavePageResult result, int64_t offline_id) {
-  // TODO(dimich): Consider adding UMA here.
+    const DownloadUIItem& item,
+    OfflinePageModel::SavePageResult result,
+    int64_t offline_id) {
+  OfflinePageNotificationBridge notification_bridge;
+  if (result == SavePageResult::SUCCESS) {

[qinmin, 2016/08/18 23:46:59]

no need for {} for if-else statements that has only 1 lines in it

[fgorski, 2016/08/19 17:03:24]

Done.

+    notification_bridge.NotifyDownloadSuccessful(item);
+  } else {
+    notification_bridge.NotifyDownloadFailed(item);
+  }
 }
 
 static jlong Init(JNIEnv* env,
                   const JavaParamRef<jobject>& obj,
                   const JavaParamRef<jobject>& j_profile) {
   Profile* profile = ProfileAndroid::FromProfileAndroid(j_profile);
   OfflinePageModel* offline_page_model =
       OfflinePageModelFactory::GetForBrowserContext(profile);
 
   DownloadUIAdapter* adapter =
       DownloadUIAdapter::FromOfflinePageModel(offline_page_model);
 
   return reinterpret_cast<jlong>(
       new OfflinePageDownloadBridge(env, obj, adapter));
 }
 
 }  // namespace android
 }  // namespace offline_pages