Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2239033002: Revert FLAGS_quic_least_unacked_packet_number_length so that it can be landed completely and then m… (Closed)

Created:
4 years, 4 months ago by Ryan Hamilton
Modified:
4 years, 4 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert FLAGS_quic_least_unacked_packet_number_length so that it can be landed completely and then merged. Committed: https://crrev.com/966f24eb56fe437c4eb4814631a5212eeeceec49 Cr-Commit-Position: refs/heads/master@{#411456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M net/quic/core/quic_connection.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M net/quic/core/quic_flags.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_flags.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 2237163002 Patch 1

Messages

Total messages: 12 (5 generated)
Ryan Hamilton
4 years, 4 months ago (2016-08-11 19:02:53 UTC) #2
Zhongyi Shi
lgtm
4 years, 4 months ago (2016-08-11 19:06:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239033002/1
4 years, 4 months ago (2016-08-11 19:06:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/276422)
4 years, 4 months ago (2016-08-11 21:57:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239033002/1
4 years, 4 months ago (2016-08-11 22:24:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 23:56:40 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 23:58:58 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/966f24eb56fe437c4eb4814631a5212eeeceec49
Cr-Commit-Position: refs/heads/master@{#411456}

Powered by Google App Engine
This is Rietveld 408576698