Use LeastUnacked to calculate the packet number length instead of GetLeastPacketAwaitedByPeer.

Use LeastUnacked to calculate the packet number length instead of GetLeastPacketAwaitedByPeer.  Protected by default enabled FLAGS_quic_least_unacked_packet_number_length.

Merge internal change: 128727157
Merge internal change: 129995365

BUG=636998
Committed: https://crrev.com/46da07b554cec9b784fbc08bc0899d9d39fc8d30
Cr-Commit-Position: refs/heads/master@{#411541}

[Ryan Hamilton, 2016-08-11 19:07:05]

rch@chromium.org changed reviewers:
+ alyssad@chromium.org, fayang@chromium.org, zhongyi@chromium.org

[Ryan Hamilton, 2016-08-11 19:07:05]

zhongyi: PTAL
fayang,alyssar: FYI

[Fan Yang, 2016-08-11 19:11:45]

On 2016/08/11 19:07:05, Ryan Hamilton wrote:
> zhongyi: PTAL
> fayang,alyssar: FYI

lgtm

Only thing is the description? maybe changed to
FLAGS_quic_least_unacked_packet_number_length?

[Zhongyi Shi, 2016-08-11 19:23:28]

LGTM! 

nit: update the issue description to strip out the internal message.

[Ryan Hamilton, 2016-08-11 19:35:43]

Description was changed from

==========
Use LeastUnacked to calculate the packet number length instead of
GetLeastPacketAwaitedByPeer.  Protected by default enabled
gfe2_reloadable_flag_quic_least_unacked_packet_number_length.

Merge internal change: 128727157
Merge internal change: 129995365

BUG=636998
==========

to

==========
Use LeastUnacked to calculate the packet number length instead of
GetLeastPacketAwaitedByPeer.  Protected by default enabled
FLAGS_quic_least_unacked_packet_number_length.

Merge internal change: 128727157
Merge internal change: 129995365

BUG=636998
==========

[Ryan Hamilton, 2016-08-11 19:35:56]

On 2016/08/11 19:23:28, Zhongyi Shi wrote:
> LGTM! 
> 
> nit: update the issue description to strip out the internal message.

Good point. Done.

[Ryan Hamilton, 2016-08-11 19:46:20]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 19:47:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 23:34:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 23:34:22]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ryan Hamilton, 2016-08-12 02:55:36]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-08-12 02:55:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2016-08-12 03:08:23]

The CQ bit was unchecked by rch@chromium.org

[Ryan Hamilton, 2016-08-12 03:08:25]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-08-12 03:08:28]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-08-12 03:08:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 03:26:57]

Description was changed from

==========
Use LeastUnacked to calculate the packet number length instead of
GetLeastPacketAwaitedByPeer.  Protected by default enabled
FLAGS_quic_least_unacked_packet_number_length.

Merge internal change: 128727157
Merge internal change: 129995365

BUG=636998
==========

to

==========
Use LeastUnacked to calculate the packet number length instead of
GetLeastPacketAwaitedByPeer.  Protected by default enabled
FLAGS_quic_least_unacked_packet_number_length.

Merge internal change: 128727157
Merge internal change: 129995365

BUG=636998
==========

[commit-bot: I haz the power, 2016-08-12 03:26:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 03:30:39]

Description was changed from

==========
Use LeastUnacked to calculate the packet number length instead of
GetLeastPacketAwaitedByPeer.  Protected by default enabled
FLAGS_quic_least_unacked_packet_number_length.

Merge internal change: 128727157
Merge internal change: 129995365

BUG=636998
==========

to

==========
Use LeastUnacked to calculate the packet number length instead of
GetLeastPacketAwaitedByPeer.  Protected by default enabled
FLAGS_quic_least_unacked_packet_number_length.

Merge internal change: 128727157
Merge internal change: 129995365

BUG=636998

Committed: https://crrev.com/46da07b554cec9b784fbc08bc0899d9d39fc8d30
Cr-Commit-Position: refs/heads/master@{#411541}
==========

[commit-bot: I haz the power, 2016-08-12 03:30:40]

Patchset 1 (id:??) landed as
https://crrev.com/46da07b554cec9b784fbc08bc0899d9d39fc8d30
Cr-Commit-Position: refs/heads/master@{#411541}